Audit: make shared actions repo visible and consumption-ready#2
Open
gambe94 wants to merge 4 commits into
Open
Audit: make shared actions repo visible and consumption-ready#2gambe94 wants to merge 4 commits into
gambe94 wants to merge 4 commits into
Conversation
… and docs The org was renamed; the old gforceinnovation name 404s and only a repo redirect keeps existing callers working. Referencing the canonical name removes the risk of the abandoned name being re-registered and hijacking action resolution. Reference snippets now point at @v1 instead of @main. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- Pin every third-party action to a full commit SHA with a # vX.Y.Z
comment (latest release within the currently-used major, so behavior
is unchanged); normalize mixed checkout/setup-node versions to v5
- Pin the actionlint download in CI to v1.7.12 instead of main
- Move ${{ inputs.* }} / step outputs out of run: scripts into env:
(script-injection hardening) in salesforce-code-analyzer, test-simple
and sf-jwt-login
- Fix required:true inputs that carry defaults (now required:false)
- Add dependabot.yml (github-actions + npm, weekly, grouped)
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Consumability audit of this repo as the org's shared
uses:target: visibility, discoverability, caller-readiness, supply-chain safety, and versioning.Already in good shape (no changes needed)
uses:works without any org Actions "Access" settingexamples/permissions:blocks; OIDC + JWT auth (no PATs);if: always()secret cleanup;dry-run: truedefaultsChanges
uses:path and doc referenced the renamed orggforceinnovation(now 404; only a repo redirect keeps it resolving). All references now useGforce-Innovation-Kft, closing an org-name re-registration hijack vector. Reference snippets point at@v1.# vX.Y.Zcomments (latest release within the currently-used major, so no behavior change); mixedcheckout@v4/@v5normalized; actionlint download pinned to v1.7.12;dependabot.ymladded (github-actions + npm, weekly, grouped) to keep pins fresh.release.yml: pushingvX.Y.Zcreates the GitHub Release and force-moves the floating major tag (v1). Strategy documented in README/GETTING_STARTED/CONTRIBUTING: pin@v1(recommended),@v1.2.0, or a SHA — never@mainin production.${{ inputs.* }}/ step-output interpolations moved out ofrun:scripts intoenv:(salesforce-code-analyzer, test-simple, sf-jwt-login); fixedrequired: trueinputs that carry defaults..github/CODEOWNERS(@gambe94) andSECURITY.md.Verification
npm run all(format + lint + typecheck + bundle + test + dist:verify) ✅actionlint 1.7.12across.github/— zero findings (fixed one pre-existing SC2086 in test-simple) ✅Manual follow-ups after merge
main, then create the first release:git tag v1.0.0 && git push origin v1.0.0(automation creates the Release +v1)gforceinnovationorg name as a placeholderGforce-Innovation-Kft/...@v1main(require CI + code-owner review)🤖 Generated with Claude Code