Repository navigation
ci(final-check): neutralise mentions and references before the bot posts - #383
Merged
Merged
Conversation
The check job runs the PR's code, which on a GitHub-hosted runner can rewrite anything later in that job, the report included. Until now only the check job cleaned that report. The comment job now cleans it too before TechEngineBot posts it: - every @ is dropped - #123, GH-123 and issue, PR and discussion links are broken - the body is capped at 65,000 characters So whatever a PR contains, the bot can't be made to mention anyone or cross-reference anything. The token text no longer says "for this repository only". One fine-grained TechEngineBot token now covers every GetTechAPI repo that has a final check. Refs #297
Seungpyo1007
force-pushed
the
ci/final-check-sanitize
branch
from
November 1, 2026 17:03
75ea1c5 to
10660cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
final-check.yml's comment job now cleans the report before TechEngineBot posts it:@is dropped.#123,GH-123and/issues/N,/pull/Nand/discussions/Nlinks are broken with a zero-width space.Why
The check job runs the PR's code. On a GitHub-hosted runner, that code can rewrite anything later in the job, the report included, and until now only the check job cleaned it. The comment job runs none of the PR's code, so cleaning there means the bot can't be used to mention people or cross-reference issues, whatever a PR contains.
The same lines are going into the other repos' final checks: GetTechAPI/TechEngine#128, GetTechAPI/TechMachine#8, GetTechAPI/game-catalog#2 and GetTechAPI/cpu-engineering-samples#37.
Checks
I ran the script, extracted from the YAML, in node against stubs:
@user,#12,GetTechAPI/TechEngine#127,GH-7and an issue URL are neutralised.Closes #297