Skip to content

feat(data): add 1 smartphone from manufacturer Wikipedia pages - #328

Merged
Seungpyo1007 merged 2 commits into
developfrom
Seungpyo1007/smartphone-wiki-recheck
Sep 29, 2026
Merged

Seungpyo1007 merged 2 commits into
developfrom
Seungpyo1007/smartphone-wiki-recheck

Conversation

@Seungpyo1007

Copy link
Copy Markdown
Member

Adds iPhone Duo, the only complete missing smartphone found after reconciling three live manufacturer Wikipedia pages against existing names, slugs and base-model variants.

Brand Reported / reproduced gaps Complete new models added Absent models blocked by SoC FK
Apple 231 1 0
Google 8 0 4
Samsung 109 0 0
Total 348 1 4

Apple: 55 comparison-column models, 54 existing and Duo absent. The raw gaps comprise 208 non-model cells, 22 existing grouped/generation aliases, and Duo. Every added field is explicit in the source column: A20 Pro, 12 GB RAM, four storage options, 5400 mAh, 254 g and iOS 27.1. Its stated 2026-10-23 release date is future; the record uses verified: false, existing apple-a20-pro, and base_model_slug: iphone-duo. No optional specs or benchmarks were guessed.

Google: 26 table rows expand to 38 models, 34 existing and four absent Pixel 11 models. The eight raw gaps comprise three headers, two existing grouped names, and three labels representing those four models. All require Tensor G6, absent from curated SoCs; the source also lacks clear weights and has a Fold-model typo. None was added.

Samsung: the raw gaps are existing aliases/families or non-model/out-of-scope cells. Every model column in its 176-row timeline was separately checked. The timeline supplies names and month/year but no hardware specs or SoC, so it yields zero complete new rows. Unmatched source-only names remain candidates for better sources; this does not establish that the whole catalog is exhausted.

Expanded rowspan/colspan grids, read actual model columns, expanded slash groups, normalized punctuation, checked both directions and existing base-model variants, and hand-reviewed ambiguous siblings. Samples include SE generations, distinct Pro Max/Pro XL models, Beam i8530 = I8530 Galaxy Beam, Ace 2 x = Ace II X S7560M, Note Fan Edition = Note FE, and Z Fold SE = Z Fold Special Edition.

Sources: iPhone models, Pixel, Samsung Galaxy list. Live audit 2026-09-29; revisions 1377138205 / 1376853504 / 1376180026.

Validation: python -m app.validate and git diff --check passed. Added source fields, SoC FK, base model and verification flag agree with generated detail/score. Unique slugs, index and manifest agree at 93,408 smartphones / 93,408 scored. The final commit refreshes the smartphone dump through TechEngine serializers; existing detail pages are unchanged and new performance scores remain null.

Closes #295

@TechEngineBot

Copy link
Copy Markdown
Member

🔎 Data verification — Tier 0 (offline existence/trust)

Scored by app.verify; posted by TechEngineBot. Informational only — the structural gate (app.validate) is separate and authoritative for merge.

12/12 categories ? 191,820 records ? diff base develop@85ff747

Changed records in this PR

1 record(s) assessed.

%%{init: {"theme":"base","themeVariables":{"pie1":"#3fb950","pie2":"#d29922","pie3":"#f85149","pieStrokeWidth":"0px","pieOpacity":"1"}}}%%
pie showData
    title Verification bands — all records
    "Green" : 1
    "Yellow" : 0
    "Red" : 0
Loading
Category Distribution Total 🟢 🟡 🔴 🟢 %
smartphone 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 1 1 0 0 100.0%
All 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 1 1 0 0 100.0%

Full-dataset baseline

191820 record(s) assessed.

%%{init: {"theme":"base","themeVariables":{"pie1":"#3fb950","pie2":"#d29922","pie3":"#f85149","pieStrokeWidth":"0px","pieOpacity":"1"}}}%%
pie showData
    title Verification bands — all records
    "Green" : 32773
    "Yellow" : 157992
    "Red" : 1055
Loading
Category Distribution Total 🟢 🟡 🔴 🟢 %
brand 🟩🟩🟩🟩🟩🟩🟩🟨🟨🟨🟨🟨 207 122 85 0 58.9%
soc 🟩🟩🟨🟨🟨🟨🟨🟥🟥🟥🟥🟥 2117 284 837 996 13.4%
smartphone 🟩🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨🟥 93408 18004 75350 54 19.3%
tablet 🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟥 3459 292 3166 1 8.4%
watch 🟩🟩🟩🟨🟨🟨🟨🟨🟨🟨🟨🟥 447 94 350 3 21.0%
pda 🟩🟩🟩🟩🟩🟩🟩🟨🟨🟨🟨🟨 140 83 57 0 59.3%
gpu 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟨🟨🟨 2076 1529 547 0 73.7%
cpu 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟨🟥 4512 4219 292 1 93.5%
laptop 🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 1995 107 1888 0 5.4%
monitor 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 882 0 882 0 0.0%
software 🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 42493 366 42127 0 0.9%
website 🟩🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 40084 7673 32411 0 19.1%
All 🟩🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨🟥 191820 32773 157992 1055 17.1%

Hard violations (forced red):

Count Check
1 !boost_ge_base

green = authoritative source + complete + consistent · yellow = plausible, needs confirmation · red = sparse/weak source or a hard contradiction. Promotion to verified runs in the scheduled verify-network workflow.

@Seungpyo1007
Seungpyo1007 merged commit 2bd6bc4 into develop Sep 29, 2026
5 checks passed
@TechEngineBot

Copy link
Copy Markdown
Member

TechEngine change review: PASS

12/12 categories ? 191,820 records ? diff base develop@85ff747

Check Result
python -m app.validate PASS
Changed dump JSON and manifest/index counts PASS
New hard integrity anomalies vs PR base PASS

Changed data

Category Added Modified Deleted Added verified Added unverified Added Kaggle-sourced
brand 0 0 0 0 0 0
soc 0 0 0 0 0 0
smartphone 1 0 0 0 1 0
tablet 0 0 0 0 0 0
watch 0 0 0 0 0 0
pda 0 0 0 0 0 0
gpu 0 0 0 0 0 0
cpu 0 0 0 0 0 0
laptop 0 0 0 0 0 0
monitor 0 0 0 0 0 0
software 0 0 0 0 0 0
website 0 0 0 0 0 0

Changed record examples

smartphone added

  • smartphone/apple/2026/iphone-duo.json - iPhone Duo

Heuristic review

  • Added records by manufacturer/brand: apple: 1
  • Added records by source class: other: 1
  • Heuristic warnings: none found.

@TechEngineBot

Copy link
Copy Markdown
Member

TechEngine validation stats: PASS

12/12 categories ? 191,820 records ? diff base develop@85ff747

Data summary

Category Total Verified Unverified Missing verified Tracked Verified % of tracked
brand 207 123 84 0 207 59.4%
soc 2117 284 1833 0 2117 13.4%
smartphone 93408 17581 75827 0 93408 18.8%
tablet 3459 288 3171 0 3459 8.3%
watch 447 94 353 0 447 21.0%
pda 140 74 66 0 140 52.9%
gpu 2076 1496 580 0 2076 72.1%
cpu 4512 4219 293 0 4512 93.5%
laptop 1995 105 1890 0 1995 5.3%
monitor 882 0 882 0 882 0.0%
software 42493 358 42135 0 42493 0.8%
website 40084 7635 32449 0 40084 19.0%
all 191820 32257 159563 0 191820 16.8%

Warning

Tracked verified coverage is below 50% for monitor 0.0% (0/882), software 0.8% (358/42493), laptop 5.3% (105/1995), tablet 8.3% (288/3459), soc 13.4% (284/2117), all 16.8% (32257/191820), smartphone 18.8% (17581/93408), website 19.0% (7635/40084), and 1 more.
Tracked coverage excludes records missing the verified field; see the Missing verified column for those records.
This does not fail validation. Keep imported records verified: false until manual audit, but treat this as follow-up verification work before relying on the affected categories as curated data.

Validation notes

  • The integrity gate blocks only hard anomalies introduced by this PR relative to its merge base.
  • Full advisory outlier listings are suppressed on successful runs because they are dataset-wide and mostly stable between PRs.
  • Failure runs still include a detailed log excerpt for debugging.

Key output:

## app.validate
## integrity_check.py (PR head compared with PR base)
loaded CPU=4512 GPU=2076
Integrity section Flagged lines
structural 0
CPU name/tier consistency (desktop mainstream only) 0
CPU single>multi (cinebench/geekbench — should be multi>=single) 0
CPU era-vs-score outliers 8
CPU cross-source ratio outliers (possible wrong-variant) 132
GPU cross-source ratio outliers + sanity 51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data Dataset changes enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Data collection: new records (workstream)

2 participants