Repository navigation
fix(data): backfill Wikipedia Commons images for 28 devices - #318
Merged
Merged
Conversation
github-actions
Bot
added
bug
Member
🔎 Data verification — Tier 0 (offline existence/trust)Scored by 12/12 categories ? 191,837 records ? diff base develop@2c2c152 Changed records in this PR28 record(s) assessed. %%{init: {"theme":"base","themeVariables":{"pie1":"#3fb950","pie2":"#d29922","pie3":"#f85149","pieStrokeWidth":"0px","pieOpacity":"1"}}}%%
pie showData
title Verification bands — all records
"Green" : 27
"Yellow" : 1
"Red" : 0
Full-dataset baseline191837 record(s) assessed. %%{init: {"theme":"base","themeVariables":{"pie1":"#3fb950","pie2":"#d29922","pie3":"#f85149","pieStrokeWidth":"0px","pieOpacity":"1"}}}%%
pie showData
title Verification bands — all records
"Green" : 32787
"Yellow" : 157995
"Red" : 1055
Hard violations (forced red):
green = authoritative source + complete + consistent · yellow = plausible, needs confirmation · red = sparse/weak source or a hard contradiction. Promotion to |
Member
TechEngine change review: PASS12/12 categories ? 191,837 records ? diff base develop@2c2c152
Changed data
Changed record examplestablet modified
watch modified
pda modified
laptop modified
Heuristic review
|
Member
TechEngine validation stats: PASS12/12 categories ? 191,837 records ? diff base develop@2c2c152
Data summary
Warning Tracked verified coverage is below 50% for monitor 0.0% (0/882), software 0.8% (358/42493), laptop 5.3% (105/1995), tablet 8.3% (288/3459), soc 13.2% (280/2117), all 16.8% (32242/191837), smartphone 18.8% (17581/93407), website 19.0% (7635/40084), and 1 more. Validation notes
Key output:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backfill 28 freely licensed Commons photos for laptop, tablet, watch and PDA records that already cite Wikipedia and lack an image URL. The existing conservative image, model-filename and license filters were preserved; only the image URL, license and attribution fields were added.
Ran the CLI from GetTechAPI/TechEngine#108 for each category:
The batches share the existing append-only
data/_verify/state/wikipedia_image_cache.jsonl: all earlier rows were preserved and 163 decisions appended, keyed by repository-relative record paths. No network errors or incompatible-record skips occurred.The final commit refreshes the affected collections through TechEngine's standard dump generator and preserves all other manifest entries. Exactly 28 detail pages changed, and each image URL was checked against its source record.
Validation:
python -m app.validatepassed against this modified data.python -m app.dump_check --base 2c2c152f2ba2 --base-ref developpassed across 12 categories and 191,837 records.Closes #295