Repository navigation
fix(data): fill Xeon and Celeron thread counts from Intel spec pages - #316
Merged
Merged
Conversation
Wikipedia lists cores only for these 23 SKUs. Each thread count is the Total Threads figure on that SKU's Intel specification page.
Adds the 23 new CPU pages. Other pages stay byte-for-byte the same; these SKUs have no benchmark scores, so CPU percentiles do not move.
github-actions
Bot
added
bug
Member
🔎 Data verification — Tier 0 (offline existence/trust)Scored by 12/12 categories ? 191,837 records ? diff base develop@ecb1d60 Changed records in this PR23 record(s) assessed. %%{init: {"theme":"base","themeVariables":{"pie1":"#3fb950","pie2":"#d29922","pie3":"#f85149","pieStrokeWidth":"0px","pieOpacity":"1"}}}%%
pie showData
title Verification bands — all records
"Green" : 23
"Yellow" : 0
"Red" : 0
Full-dataset baseline191837 record(s) assessed. %%{init: {"theme":"base","themeVariables":{"pie1":"#3fb950","pie2":"#d29922","pie3":"#f85149","pieStrokeWidth":"0px","pieOpacity":"1"}}}%%
pie showData
title Verification bands — all records
"Green" : 32787
"Yellow" : 157995
"Red" : 1055
Hard violations (forced red):
green = authoritative source + complete + consistent · yellow = plausible, needs confirmation · red = sparse/weak source or a hard contradiction. Promotion to |
Member
TechEngine change review: PASS12/12 categories ? 191,837 records ? diff base develop@ecb1d60
Changed data
Changed record examplescpu added
Heuristic review
|
Member
TechEngine validation stats: PASS12/12 categories ? 191,837 records ? diff base develop@ecb1d60
Data summary
Warning Tracked verified coverage is below 50% for monitor 0.0% (0/882), software 0.8% (358/42493), laptop 5.3% (105/1995), tablet 8.3% (288/3459), soc 13.2% (280/2117), all 16.8% (32242/191837), smartphone 18.8% (17581/93407), website 19.0% (7635/40084), and 1 more. Validation notes
Key output:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
23 older Xeon and Celeron SKUs whose Wikipedia list rows give a core count and no thread count. Each
threadsvalue is the Total Threads figure on that exact SKU's Intel specification page. Thread count was not inferred from the core count or from Hyper-Threading.Of the 83 SKUs in this batch that are still absent from the dataset, 23 were filled and 60 were skipped.
Filled (7 Celeron, 16 Xeon):
Two of these are not "threads = 2 × cores": Celeron P1053 is 1 core / 2 threads (the Intel page says Hyper-Threading Yes and Total Threads 2), and Xeon EC5509 is 4 cores / 4 threads (Hyper-Threading No). Xeon LC3518 is 1 core / 1 thread.
Skipped, 60:
verifiedstays false.python -m app.validatepasses. The last commit refreshes the static dump: 23 new CPU pages, CPU count 4507 → 4530. These SKUs have no benchmark scores, so the scored-CPU count does not change.Closes #296
Source
Intel product specification pages (Wayback capture of the same page when the live URL no longer resolves), plus the Wikipedia Xeon and Celeron list page for the row. Each record's
source_urlscites both.Checklist
develop(mainonly moves through release PRs)python -m app.validatepasses locallydata/<category>/<...>/<slug>.jsonpathsource_urlscites at least one canonical reference