Repository navigation
ci(repo): stop browsers caching the hosted web index.html - #1622
Merged
Merged
Conversation
Revalidating a cached app route on flutter.getstream.io returns an empty 200, which leaves join links blank on a second visit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
Codecov Report✔️ No coverage data to report, because files changed do not require tests or are set to ignore |
razkevich
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Join links on flutter.getstream.io (e.g.
/video/beta/join/<id>) sometimes open to a blank page.Routes like
/join/<id>aren't files in the bucket, so the load balancer servesindex.htmlfor them. When the browser revalidates its cached copy (If-None-Match), the fallback fetchesindex.htmlwith that header, gets a304, and rewrites it to200with an empty body. The browser stores the empty page, and every later revalidation returns the same thing.A trailing
/only seemed to help because the browser caches it as a different URL. The first visit works and a reload within 60 s goes blank.Change
rsyncleavesindex.htmlout.index.htmlis then uploaded on its own withCache-Control: no-store, so browsers never store it and never send a conditional request for an app route. It is also uploaded last, after the assets it references.Testing
curl -sI https://flutter.getstream.io/video/beta/index.htmlshowscache-control: no-storeThe deployer service account needs to be able to overwrite
index.html.rsyncalready overwrites objects, so it should.🤖 Generated with Claude Code