Skip to content

[WIP] Fix regression when foreground call service is disabled#1729

Draft
rahul-lohra wants to merge 5 commits into
developfrom
bugfix/rahullohra/background-call-disabled-regression
Draft

[WIP] Fix regression when foreground call service is disabled#1729
rahul-lohra wants to merge 5 commits into
developfrom
bugfix/rahullohra/background-call-disabled-regression

Conversation

@rahul-lohra

Copy link
Copy Markdown
Contributor

Goal

This change fixes a regression introduced while adding support for configurations where runCallServiceInForeground is disabled.

Implementation

Describe the implementation

🎨 UI Changes

None

Testing

Smoke test 1-1 calls, normal calls

@rahul-lohra rahul-lohra self-assigned this Jun 19, 2026
@rahul-lohra rahul-lohra added the pr:bug Fixes a bug label Jun 19, 2026
@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

PR checklist ❌

The following issues were detected:

  • Linked issue missing. Add a Linear ticket reference (e.g. AND-123, Closes AND-123, or a https://linear.app/... link) or a GitHub issue (Closes #123) to the PR description.

What we check

  1. Title is concise (5–18 words) unless labeled pr:ignore-for-release.
  2. At least one pr: label exists (e.g., pr:bug, pr:new-feature).
  3. Sections ### Goal, ### Implementation, and ### Testing contain content. Bot-authored PRs are exempt.
  4. PR description references an issue (Linear ticket like AND-123, a Linear URL, or a GitHub Closes #N). Bot-authored PRs are exempt.

@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

SDK Size Comparison 📏

SDK Before After Difference Status
stream-video-android-core 12.27 MB 12.27 MB 0.00 MB 🟢
stream-video-android-ui-xml 5.68 MB 5.68 MB 0.00 MB 🟢
stream-video-android-ui-compose 6.28 MB 6.28 MB 0.00 MB 🟢

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
31.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:bug Fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant