add logic for version 4 and 5 - #33
Closed
arcisad wants to merge 20 commits into
Closed
Conversation
arcisad
force-pushed
the
research/rema-timeseries-versions
branch
from
June 11, 2026 23:46
b3dffe9 to
79981cc
Compare
abradley60
approved these changes
Jun 12, 2026
|
|
||
| rema_version = rema_remote_config_data["resolution"][str(resolution)] | ||
| rema_remote_config = rema_remote_config_data[rema_version] | ||
| aoi_name = rema_remote_config_data["aoi_name"][rema_version] |
Collaborator
There was a problem hiding this comment.
This could maybe be hardcoded as thwaites if thats the only area in v0.3 and v0.4, so one less input in the config is needed. v0.5 moves to tiles we wont need to worry about it
Collaborator
There was a problem hiding this comment.
Ignore this - fine as is
arcisad
force-pushed
the
research/rema-timeseries-versions
branch
from
June 12, 2026 03:25
041d6ce to
3122ca3
Compare
abradley60
approved these changes
Aug 7, 2026
abradley60
left a comment
abradley60
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to come in Amir. Do you think there's any value in adding something small to the docs on the MT dem i.e. very basic instructions? - can add this later.
arcisad
force-pushed
the
research/rema-timeseries-versions
branch
from
August 10, 2026 03:07
52bf2ab to
f74be5e
Compare
arcisad
force-pushed
the
research/rema-timeseries-versions
branch
2 times, most recently
from
August 10, 2026 04:42
d036a43 to
8bbb229
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds logic for REMA timeseries v 0.4 and 0.5. A PR just to highlight the changes!