fix(Logger): replace warn with warning by BenPinet · Pull Request #1312 · Geode-solutions/OpenGeode

BenPinet · 2026-08-03T09:31:53Z

BREAKING CHANGE: change members name in Logger struct

github-actions · 2026-08-03T09:46:35Z

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v20.1.8) reports: 84 concern(s)

include/geode/basic/console_logger_client.hpp:32:31: warning: [cppcoreguidelines-special-member-functions]

class 'ConsoleLoggerClient' defines a destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator
```
   32 |     class opengeode_basic_api ConsoleLoggerClient : public LoggerClient
      |                               ^
```

include/geode/basic/console_logger_client.hpp:36:9: warning: [cppcoreguidelines-explicit-virtual-functions]

annotate this function with 'override' or (rarely) 'final'

   36 |         ~ConsoleLoggerClient();
      |         ^                     
      |                                override

include/geode/basic/input.hpp:64:11: warning: [cppcoreguidelines-special-member-functions]

class 'Input' defines a non-default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator
```
   64 |     class Input : public IOFile
      |           ^
```
include/geode/basic/input.hpp:77:9: warning: [cppcoreguidelines-explicit-virtual-functions]

annotate this function with 'override' or (rarely) 'final'
```
   77 |         ~Input()
      |         ^       
      |                  override
```
include/geode/basic/logger.hpp:41:31: warning: [cppcoreguidelines-special-member-functions]

class 'Logger' defines a destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator
```
   41 |     class opengeode_basic_api Logger
      |                               ^
```
include/geode/basic/logger_client.hpp:30:31: warning: [cppcoreguidelines-special-member-functions]

class 'LoggerClient' defines a default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator
```
   30 |     class opengeode_basic_api LoggerClient
      |                               ^
```
include/geode/basic/logger_manager.hpp:36:31: warning: [cppcoreguidelines-special-member-functions]

class 'LoggerManager' defines a destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator
```
   36 |     class opengeode_basic_api LoggerManager
      |                               ^
```
src/geode/basic/console_logger_client.cpp:27:10: error: [clang-diagnostic-error]

'spdlog/spdlog.h' file not found
```
   27 | #include <spdlog/spdlog.h>
      |          ^~~~~~~~~~~~~~~~~
```
src/geode/basic/console_logger_client.cpp:40:9: warning: [cppcoreguidelines-pro-type-member-init]

constructor does not initialize these fields: logger_impl_
```
   40 |         Impl() : logger_impl_( spdlog::stdout_color_mt( "console" ) )
      |         ^
```
src/geode/basic/console_logger_client.cpp:40:9: warning: [hicpp-use-equals-default]

use '= default' to define a trivial default constructor
src/geode/basic/file_logger_client.cpp:27:10: error: [clang-diagnostic-error]

'spdlog/spdlog.h' file not found
```
   27 | #include <spdlog/spdlog.h>
      |          ^~~~~~~~~~~~~~~~~
```

src/geode/basic/file_logger_client.cpp:55:27: warning: [readability-identifier-naming]

invalid case style for variable 'LOGGER_NAME'

   55 |             spdlog::drop( LOGGER_NAME );
      |                           ^~~~~~~~~~~
      |                           logger_name

src/geode/basic/logger.cpp:36:9: warning: [modernize-use-nodiscard]

function 'level' should be marked [[nodiscard]]
```
   36 |         LEVEL level() const
      |         ^
      |         [[nodiscard]] 
```
src/geode/basic/logger.cpp:102:13: warning: [readability-identifier-naming]

invalid case style for private member 'leveled_log'
```
   48 |             leveled_log{
      |             ^~~~~~~~~~~
      |             leveled_log_
```

src/geode/mesh/helpers/detail/surface_merger.cpp:61:1: warning: [modernize-concat-nested-namespaces]

nested namespaces can be concatenated

   61 | namespace geode
      | ^~~~~~~~~~~~~~~
   62 | {
      | ~
   63 |     namespace detail
      |     ~~~~~~~~~~~~~~~~
      |     namespace geode::detail

src/geode/mesh/helpers/detail/surface_merger.cpp:73:13: warning: [google-explicit-constructor]

single-argument constructors must be marked explicit to avoid unintentional implicit conversions
```
   73 |             Impl( absl::Span< const std::reference_wrapper<
      |             ^
      |             explicit 
```
src/geode/mesh/helpers/detail/surface_merger.cpp:78:33: warning: [readability-identifier-length]

variable name 's' is too short, expected at least 3 characters
```
   78 |                 for( const auto s : Indices{ surfaces } )
      |                                 ^
```
src/geode/mesh/helpers/detail/surface_merger.cpp:111:13: warning: [modernize-use-nodiscard]

function 'polygon_in_merged' should be marked [[nodiscard]]
```
  111 |             index_t polygon_in_merged(
      |             ^
      |             [[nodiscard]] 
```

src/geode/mesh/helpers/detail/surface_merger.cpp:127:13: warning: [modernize-use-nodiscard]

function 'polygon_origins' should be marked [[nodiscard]]

  127 |             const PolygonOrigins& polygon_origins( index_t polygon ) const
      |             ^
      |             [[nodiscard]]

src/geode/mesh/helpers/detail/surface_merger.cpp:147:18: warning: [readability-function-cognitive-complexity]

function 'create_polygons' has cognitive complexity of 13 (threshold 10)

  147 |             void create_polygons( SurfaceMeshMerger< dimension >& merger )
      |                  ^
/__w/OpenGeode/OpenGeode/src/geode/mesh/helpers/detail/surface_merger.cpp:151:17: note: +1, including nesting penalty of 0, nesting level increased to 1
  151 |                 for( const auto s : Indices{ merger.meshes() } )
      |                 ^
/__w/OpenGeode/OpenGeode/src/geode/mesh/helpers/detail/surface_merger.cpp:154:21: note: +2, including nesting penalty of 1, nesting level increased to 2
  154 |                     for( const auto p : Range{ surface.nb_polygons() } )
      |                     ^
/__w/OpenGeode/OpenGeode/src/geode/mesh/helpers/detail/surface_merger.cpp:157:25: note: +3, including nesting penalty of 2, nesting level increased to 3
  157 |                         for( const auto v :
      |                         ^
/__w/OpenGeode/OpenGeode/src/geode/mesh/helpers/detail/surface_merger.cpp:163:25: note: +3, including nesting penalty of 2, nesting level increased to 3
  163 |                         if( is_polygon_degenerated( vertices ) )
      |                         ^
/__w/OpenGeode/OpenGeode/src/geode/mesh/helpers/detail/surface_merger.cpp:170:25: note: +3, including nesting penalty of 2, nesting level increased to 3
  170 |                         if( it.second )
      |                         ^
/__w/OpenGeode/OpenGeode/src/geode/mesh/helpers/detail/surface_merger.cpp:188:25: note: +1, nesting level increased to 3
  188 |                         else
      |                         ^

src/geode/mesh/helpers/detail/surface_merger.cpp:151:33: warning: [readability-identifier-length]

variable name 's' is too short, expected at least 3 characters
```
  151 |                 for( const auto s : Indices{ merger.meshes() } )
      |                                 ^
```
src/geode/mesh/helpers/detail/surface_merger.cpp:167:36: warning: [readability-identifier-length]

variable name 'it' is too short, expected at least 3 characters
```
  167 |                         const auto it =
      |                                    ^
```

src/geode/mesh/helpers/detail/surface_merger.cpp:207:18: warning: [readability-function-cognitive-complexity]

function 'create_adjacencies' has cognitive complexity of 16 (threshold 10)

  207 |             void create_adjacencies( SurfaceMeshMerger< dimension >& merger )
      |                  ^
/__w/OpenGeode/OpenGeode/src/geode/mesh/helpers/detail/surface_merger.cpp:210:17: note: +1, including nesting penalty of 0, nesting level increased to 1
  210 |                 for( const auto p : Range{ merger.mesh().nb_polygons() } )
      |                 ^
/__w/OpenGeode/OpenGeode/src/geode/mesh/helpers/detail/surface_merger.cpp:212:21: note: +2, including nesting penalty of 1, nesting level increased to 2
  212 |                     for( const auto e :
      |                     ^
/__w/OpenGeode/OpenGeode/src/geode/mesh/helpers/detail/surface_merger.cpp:218:25: note: +3, including nesting penalty of 2, nesting level increased to 3
  218 |                         if( !adj )
      |                         ^
/__w/OpenGeode/OpenGeode/src/geode/mesh/helpers/detail/surface_merger.cpp:225:25: note: +3, including nesting penalty of 2, nesting level increased to 3
  225 |                         for( const auto& origin : polygons_origins_[p] )
      |                         ^
/__w/OpenGeode/OpenGeode/src/geode/mesh/helpers/detail/surface_merger.cpp:231:29: note: +4, including nesting penalty of 3, nesting level increased to 4
  231 |                             if( !surface.is_edge_on_border( edge_origin ) )
      |                             ^
/__w/OpenGeode/OpenGeode/src/geode/mesh/helpers/detail/surface_merger.cpp:237:25: note: +3, including nesting penalty of 2, nesting level increased to 3
  237 |                         if( !keep_adj )
      |                         ^

src/geode/mesh/helpers/detail/surface_merger.cpp:247:25: warning: [readability-function-cognitive-complexity]

function 'find_edge_origin' has cognitive complexity of 12 (threshold 10)

  247 |             PolygonEdge find_edge_origin(
      |                         ^
/__w/OpenGeode/OpenGeode/src/geode/mesh/helpers/detail/surface_merger.cpp:255:43: note: nesting level increased to 1
  255 |                 const auto is_same_edge = [&merger, &merged_edge_vertices,
      |                                           ^
/__w/OpenGeode/OpenGeode/src/geode/mesh/helpers/detail/surface_merger.cpp:258:21: note: +2, including nesting penalty of 1, nesting level increased to 2
  258 |                     for( const auto vertex :
      |                     ^
/__w/OpenGeode/OpenGeode/src/geode/mesh/helpers/detail/surface_merger.cpp:263:25: note: +3, including nesting penalty of 2, nesting level increased to 3
  263 |                         if( merged_vertex != merged_edge_vertices[0]
      |                         ^
/__w/OpenGeode/OpenGeode/src/geode/mesh/helpers/detail/surface_merger.cpp:264:29: note: +1
  264 |                             && merged_vertex != merged_edge_vertices[1] )
      |                             ^
/__w/OpenGeode/OpenGeode/src/geode/mesh/helpers/detail/surface_merger.cpp:272:17: note: +1, including nesting penalty of 0, nesting level increased to 1
  272 |                 if( is_same_edge( hint_edge ) )
      |                 ^
/__w/OpenGeode/OpenGeode/src/geode/mesh/helpers/detail/surface_merger.cpp:276:17: note: +1, including nesting penalty of 0, nesting level increased to 1
  276 |                 for( const auto& e :
      |                 ^
/__w/OpenGeode/OpenGeode/src/geode/mesh/helpers/detail/surface_merger.cpp:279:21: note: +2, including nesting penalty of 1, nesting level increased to 2
  279 |                     if( e == hint )
      |                     ^
/__w/OpenGeode/OpenGeode/src/geode/mesh/helpers/detail/surface_merger.cpp:284:21: note: +2, including nesting penalty of 1, nesting level increased to 2
  284 |                     if( is_same_edge( edge ) )
      |                     ^

src/geode/model/helpers/aabb_model_helpers.cpp:78:24: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
   78 |         geode::index_t id{ 0 };
      |                        ^
```
src/geode/model/helpers/aabb_model_helpers.cpp:109:24: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  109 |         geode::index_t id{ 0 };
      |                        ^
```
src/geode/model/helpers/surface_radial_sort.cpp:61:21: warning: [hicpp-move-const-arg]

std::move of the variable 'edge_in' of the trivially-copyable type 'geode::PolygonEdge' has no effect; remove std::move()
```
   61 |               edge( std::move( edge_in ) ),
      |                     ^~~~~~~~~~         ~
```

src/geode/model/helpers/surface_radial_sort.cpp:62:53: warning: [bugprone-use-after-move]

'edge_in' used after it was moved

   62 |               opposite_point{ opposite( surface_in, edge_in ) }
      |                                                     ^
/__w/OpenGeode/OpenGeode/src/geode/model/helpers/surface_radial_sort.cpp:61:15: note: move occurred here
   61 |               edge( std::move( edge_in ) ),
      |               ^

src/geode/model/helpers/surface_radial_sort.cpp:92:53: warning: [readability-function-cognitive-complexity]

function 'border_polygons' has cognitive complexity of 11 (threshold 10)

   92 |     std::pair< bool, std::vector< BorderPolygon > > border_polygons(
      |                                                     ^
/__w/OpenGeode/OpenGeode/src/geode/model/helpers/surface_radial_sort.cpp:104:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  104 |         for( const auto& vertex_pairs :
      |         ^
/__w/OpenGeode/OpenGeode/src/geode/model/helpers/surface_radial_sort.cpp:111:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  111 |             for( const auto& pair : vertex_pairs.second )
      |             ^
/__w/OpenGeode/OpenGeode/src/geode/model/helpers/surface_radial_sort.cpp:113:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  113 |                 if( auto edge0 = surface_mesh.polygon_edge_from_vertices(
      |                 ^
/__w/OpenGeode/OpenGeode/src/geode/model/helpers/surface_radial_sort.cpp:119:42: note: +1
  119 |                                          || surface_mesh.is_polygon_degenerated(
      |                                          ^
/__w/OpenGeode/OpenGeode/src/geode/model/helpers/surface_radial_sort.cpp:122:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  122 |                 if( auto edge1 = surface_mesh.polygon_edge_from_vertices(
      |                 ^
/__w/OpenGeode/OpenGeode/src/geode/model/helpers/surface_radial_sort.cpp:128:42: note: +1
  128 |                                          || surface_mesh.is_polygon_degenerated(
      |                                          ^

src/geode/model/helpers/surface_radial_sort.cpp:95:24: warning: [readability-identifier-length]

parameter name 'e0' is too short, expected at least 3 characters
```
   95 |         geode::index_t e0,
      |                        ^
```
src/geode/model/helpers/surface_radial_sort.cpp:96:24: warning: [readability-identifier-length]

parameter name 'e1' is too short, expected at least 3 characters
```
   96 |         geode::index_t e1 )
      |                        ^
```
src/geode/model/helpers/surface_radial_sort.cpp:117:40: warning: [hicpp-move-const-arg]

std::move of the expression of the trivially-copyable type 'geode::PolygonEdge' has no effect; remove std::move()
```
  117 |                         surface, true, std::move( edge0.value() ) );
      |                                        ^~~~~~~~~~               ~
```
src/geode/model/helpers/surface_radial_sort.cpp:126:41: warning: [hicpp-move-const-arg]

std::move of the expression of the trivially-copyable type 'geode::PolygonEdge' has no effect; remove std::move()
```
  126 |                         surface, false, std::move( edge1.value() ) );
      |                                         ^~~~~~~~~~               ~
```

src/geode/model/helpers/surface_radial_sort.cpp:151:17: warning: [readability-implicit-bool-conversion]

implicit conversion 'bool' -> 'local_index_t' (aka 'unsigned char')

  151 |                 !polygon.same_orientation, polygon.edge };
      |                 ^                        
      |                 static_cast<local_index_t>( )

src/geode/model/helpers/surface_radial_sort.cpp:153:17: warning: [readability-implicit-bool-conversion]

implicit conversion 'bool' -> 'local_index_t' (aka 'unsigned char')

  153 |                 polygon.same_orientation, polygon.edge };
      |                 ^                       
      |                 static_cast<local_index_t>( )

src/geode/model/helpers/surface_radial_sort.cpp:162:21: warning: [bugprone-implicit-widening-of-multiplication-result]

performing an implicit widening conversion to type 'size_type' (aka 'unsigned long') of a multiplication performed in type 'index_t' (aka 'unsigned int')

  162 |         : surfaces( 2 * nb_surfaces )
      |                     ^
/__w/OpenGeode/OpenGeode/src/geode/model/helpers/surface_radial_sort.cpp:162:21: note: make conversion explicit to silence this warning
   24 |         : surfaces( 2 * nb_surfaces )
      |                     ^~~~~~~~~~~~~~~
      |                     static_cast<size_type>( )
/__w/OpenGeode/OpenGeode/src/geode/model/helpers/surface_radial_sort.cpp:162:21: note: perform multiplication in a wider type
  162 |         : surfaces( 2 * nb_surfaces )
      |                     ^
      |                     static_cast<size_type>( )

src/geode/model/helpers/surface_radial_sort.cpp:190:17: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  190 |         index_t id{ 0 };
      |                 ^
```
src/geode/model/helpers/surface_radial_sort.cpp:191:26: warning: [readability-identifier-length]

variable name 's' is too short, expected at least 3 characters
```
  191 |         for( const auto& s : surfaces )
      |                          ^
```
src/geode/model/helpers/surface_radial_sort.cpp:207:24: warning: [readability-identifier-length]

variable name 'e0' is too short, expected at least 3 characters
```
  207 |             const auto e0 = mesh.edge_vertex( { edge_id, 0 } );
      |                        ^
```
src/geode/model/helpers/surface_radial_sort.cpp:208:24: warning: [readability-identifier-length]

variable name 'e1' is too short, expected at least 3 characters
```
  208 |             const auto e1 = mesh.edge_vertex( { edge_id, 1 } );
      |                        ^
```
src/geode/model/helpers/surface_radial_sort.cpp:226:25: warning: [readability-identifier-length]

variable name 'p0' is too short, expected at least 3 characters
```
  226 |             const auto& p0 = line.mesh().point( e0 );
      |                         ^
```
src/geode/model/helpers/surface_radial_sort.cpp:227:25: warning: [readability-identifier-length]

variable name 'p1' is too short, expected at least 3 characters
```
  227 |             const auto& p1 = line.mesh().point( e1 );
      |                         ^
```

src/geode/model/mixin/core/detail/relationships_impl.cpp:40:1: warning: [modernize-concat-nested-namespaces]

nested namespaces can be concatenated

   40 | namespace geode
      | ^~~~~~~~~~~~~~~
   41 | {
      | ~
   42 |     namespace detail
      |     ~~~~~~~~~~~~~~~~
      |     namespace geode::detail

src/geode/model/mixin/core/detail/relationships_impl.cpp:49:55: warning: [hicpp-named-parameter]

all parameters should be named in a function

   49 |         RelationshipsImpl::RelationshipsImpl( BITSERY ) {}
      |                                                       ^
      |                                                        /*unused*/

src/geode/model/mixin/core/detail/relationships_impl.cpp:122:57: warning: [readability-identifier-length]

parameter name 'to' is too short, expected at least 3 characters
```
  122 |             const ComponentID& from, const ComponentID& to )
      |                                                         ^
```
src/geode/model/mixin/core/detail/relationships_impl.cpp:254:24: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  254 |             const auto id =
      |                        ^
```
src/geode/model/mixin/core/relationships.cpp:61:18: warning: [readability-redundant-member-init]

initializer for base class 'detail::RelationshipsImpl' is redundant
```
   61 |         Impl() : RelationshipsImpl()
      |                  ^~~~~~~~~~~~~~~~~~~
```
src/geode/model/mixin/core/relationships.cpp:66:9: warning: [google-explicit-constructor]

single-argument constructors must be marked explicit to avoid unintentional implicit conversions
```
   66 |         Impl( BITSERY bitsery ) : RelationshipsImpl( bitsery ) {}
      |         ^
      |         explicit 
```

src/geode/model/mixin/core/relationships.cpp:68:9: warning: [modernize-use-nodiscard]

function 'relation_type' should be marked [[nodiscard]]

   68 |         RelationType relation_type( const index_t edge_id ) const
      |         ^
      |         [[nodiscard]]

src/geode/model/mixin/core/relationships.cpp:73:9: warning: [modernize-use-nodiscard]

function 'is_boundary_relation' should be marked [[nodiscard]]

   73 |         bool is_boundary_relation( const index_t edge_id ) const
      |         ^
      |         [[nodiscard]]

src/geode/model/mixin/core/relationships.cpp:78:9: warning: [modernize-use-nodiscard]

function 'is_internal_relation' should be marked [[nodiscard]]

   78 |         bool is_internal_relation( const index_t edge_id ) const
      |         ^
      |         [[nodiscard]]

src/geode/model/mixin/core/relationships.cpp:83:9: warning: [modernize-use-nodiscard]

function 'is_item_relation' should be marked [[nodiscard]]

   83 |         bool is_item_relation( const index_t edge_id ) const
      |         ^
      |         [[nodiscard]]

src/geode/model/mixin/core/relationships.cpp:88:9: warning: [modernize-use-nodiscard]

function 'check_relation_exists' should be marked [[nodiscard]]
```
   88 |         std::optional< index_t > check_relation_exists(
      |         ^
      |         [[nodiscard]] 
```

src/geode/model/mixin/core/relationships.cpp:89:43: warning: [readability-identifier-length]

parameter name 'to' is too short, expected at least 3 characters

   89 |             const uuid& from, const uuid& to, const RelationType type ) const
      |                                           ^

src/geode/model/mixin/core/relationships.cpp:101:9: warning: [modernize-use-nodiscard]

function 'is_boundary' should be marked [[nodiscard]]

  101 |         bool is_boundary( const uuid& from, const uuid& to ) const
      |         ^
      |         [[nodiscard]]

src/geode/model/mixin/core/relationships.cpp:101:57: warning: [readability-identifier-length]

parameter name 'to' is too short, expected at least 3 characters

  101 |         bool is_boundary( const uuid& from, const uuid& to ) const
      |                                                         ^

src/geode/model/mixin/core/relationships.cpp:115:9: warning: [modernize-use-nodiscard]

function 'is_internal' should be marked [[nodiscard]]

  115 |         bool is_internal( const uuid& from, const uuid& to ) const
      |         ^
      |         [[nodiscard]]

src/geode/model/mixin/core/relationships.cpp:115:57: warning: [readability-identifier-length]

parameter name 'to' is too short, expected at least 3 characters

  115 |         bool is_internal( const uuid& from, const uuid& to ) const
      |                                                         ^

src/geode/model/mixin/core/relationships.cpp:129:9: warning: [modernize-use-nodiscard]

function 'is_item' should be marked [[nodiscard]]

  129 |         bool is_item( const uuid& from, const uuid& to ) const
      |         ^
      |         [[nodiscard]]

src/geode/model/mixin/core/relationships.cpp:129:53: warning: [readability-identifier-length]

parameter name 'to' is too short, expected at least 3 characters

  129 |         bool is_item( const uuid& from, const uuid& to ) const
      |                                                     ^

src/geode/model/mixin/core/relationships.cpp:143:32: warning: [readability-identifier-length]

parameter name 'to' is too short, expected at least 3 characters
```
  143 |             const ComponentID& to,
      |                                ^
```

src/geode/model/mixin/core/relationships.cpp:259:13: warning: [cppcoreguidelines-pro-type-member-init]

uninitialized record type: 'ids_attribute_values'

  259 |             AttributeValues< RelationType > ids_attribute_values;
      |             ^                                                   
      |                                                                 {}

src/geode/model/mixin/core/relationships.cpp:262:24: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  262 |             const auto id =
      |                        ^
```
src/geode/model/mixin/core/relationships.cpp:272:9: warning: [modernize-use-nodiscard]

function 'relation_to_string' should be marked [[nodiscard]]
```
  272 |         std::string relation_to_string( index_t relation_type ) const
      |         ^
      |         [[nodiscard]] 
```
src/geode/model/mixin/core/relationships.cpp:462:9: warning: [readability-avoid-return-with-void-value]

return statement within a void function should not have a specified return value
```
  462 |         return impl_->load( directory );
      |         ^~~~~~
```
src/geode/model/mixin/core/relationships.cpp:501:9: warning: [modernize-use-nodiscard]

function 'graph_component_id' should be marked [[nodiscard]]
```
  501 |         const ComponentID& graph_component_id() const
      |         ^
      |         [[nodiscard]] 
```

src/geode/model/mixin/core/relationships.cpp:503:13: warning: [llvm-qualified-auto]

'const auto iterator' can be declared as 'const auto *const iterator'

  503 |             const auto iterator = this->current();
      |             ^~~~~~~~~~
      |             const auto *const

src/geode/model/mixin/core/relationships.cpp:567:9: warning: [modernize-use-nodiscard]

function 'graph_component_id' should be marked [[nodiscard]]
```
  567 |         const ComponentID& graph_component_id() const
      |         ^
      |         [[nodiscard]] 
```

src/geode/model/mixin/core/relationships.cpp:569:13: warning: [llvm-qualified-auto]

'const auto iterator' can be declared as 'const auto *const iterator'

  569 |             const auto iterator = this->current();
      |             ^~~~~~~~~~
      |             const auto *const

src/geode/model/mixin/core/relationships.cpp:651:9: warning: [modernize-use-nodiscard]

function 'graph_component_id' should be marked [[nodiscard]]
```
  651 |         const ComponentID& graph_component_id() const
      |         ^
      |         [[nodiscard]] 
```

src/geode/model/mixin/core/relationships.cpp:653:13: warning: [llvm-qualified-auto]

'const auto iterator' can be declared as 'const auto *const iterator'

  653 |             const auto iterator = this->current();
      |             ^~~~~~~~~~
      |             const auto *const

src/geode/model/mixin/core/relationships.cpp:735:9: warning: [modernize-use-nodiscard]

function 'graph_component_id' should be marked [[nodiscard]]
```
  735 |         const ComponentID& graph_component_id() const
      |         ^
      |         [[nodiscard]] 
```

src/geode/model/mixin/core/relationships.cpp:737:13: warning: [llvm-qualified-auto]

'const auto iterator' can be declared as 'const auto *const iterator'

  737 |             const auto iterator = this->current();
      |             ^~~~~~~~~~
      |             const auto *const

src/geode/model/mixin/core/relationships.cpp:819:9: warning: [modernize-use-nodiscard]

function 'graph_component_id' should be marked [[nodiscard]]
```
  819 |         const ComponentID& graph_component_id() const
      |         ^
      |         [[nodiscard]] 
```

src/geode/model/mixin/core/relationships.cpp:821:13: warning: [llvm-qualified-auto]

'const auto iterator' can be declared as 'const auto *const iterator'

  821 |             const auto iterator = this->current();
      |             ^~~~~~~~~~
      |             const auto *const

src/geode/model/mixin/core/relationships.cpp:903:9: warning: [modernize-use-nodiscard]

function 'graph_component_id' should be marked [[nodiscard]]
```
  903 |         const ComponentID& graph_component_id() const
      |         ^
      |         [[nodiscard]] 
```

src/geode/model/mixin/core/relationships.cpp:905:13: warning: [llvm-qualified-auto]

'const auto iterator' can be declared as 'const auto *const iterator'

  905 |             const auto iterator = this->current();
      |             ^~~~~~~~~~
      |             const auto *const

src/geode/model/mixin/core/relationships.cpp:987:9: warning: [modernize-use-nodiscard]

function 'graph_component_id' should be marked [[nodiscard]]
```
  987 |         const ComponentID& graph_component_id() const
      |         ^
      |         [[nodiscard]] 
```

src/geode/model/mixin/core/relationships.cpp:989:13: warning: [llvm-qualified-auto]

'const auto iterator' can be declared as 'const auto *const iterator'

  989 |             const auto iterator = this->current();
      |             ^~~~~~~~~~
      |             const auto *const

tests/basic/test-logger.cpp:85:30: warning: [readability-identifier-naming]

invalid case style for variable 'MSG_SIZE'

   85 |         const geode::index_t MSG_SIZE{ 100000 };
      |                              ^~~~~~~~
      |                              msg_size
   86 |         huge_message.reserve( MSG_SIZE );
      |                               ~~~~~~~~
      |                               msg_size
   87 |         for( const auto count : geode::Range{ MSG_SIZE } )
      |                                               ~~~~~~~~
      |                                               msg_size

tests/basic/test-logger.cpp:89:37: warning: [bugprone-narrowing-conversions]

narrowing conversion from 'unsigned int' to signed type 'char' is implementation-defined
```
   89 |             huge_message.push_back( 'A' + ( count % 26 ) );
      |                                     ^
```
tests/basic/test-logger.cpp:89:53: warning: [cppcoreguidelines-avoid-magic-numbers]

26 is a magic number; consider replacing it with a named constant
```
   89 |             huge_message.push_back( 'A' + ( count % 26 ) );
      |                                                     ^
```

tests/basic/test-logger.cpp:95:62: warning: [cppcoreguidelines-avoid-magic-numbers]

50 is a magic number; consider replacing it with a named constant

   95 |             "Huge message begin = ", huge_message.substr( 0, 50 ) );
      |                                                              ^

tests/basic/test-logger.cpp:97:56: warning: [cppcoreguidelines-avoid-magic-numbers]

50 is a magic number; consider replacing it with a named constant
```
   97 |             huge_message.substr( huge_message.size() - 50 ) );
      |                                                        ^
```

Have any feedback or feature suggestions? Share it here.

fix(Logger): replace warn with warning

f2ae8f8

BREAKING CHANGE: change members name in Logger struct

BenPinet requested a review from BotellaA August 3, 2026 09:31

BotellaA approved these changes Aug 3, 2026

View reviewed changes

BotellaA merged commit e2fd4c6 into v18 Aug 3, 2026
20 checks passed

BotellaA deleted the feat/replace_replace_warn_with_warning branch August 3, 2026 14:33

Navigation Menu

Uh oh!

Uh oh!

fix(Logger): replace warn with warning - #1312

fix(Logger): replace warn with warning#1312
BotellaA merged 1 commit into
v18from
feat/replace_replace_warn_with_warning

BenPinet commented Aug 3, 2026

Uh oh!

github-actions Bot commented Aug 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

BenPinet commented Aug 3, 2026

Uh oh!

github-actions Bot commented Aug 3, 2026

Cpp-Linter Report ⚠️

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants