Skip to content

fix(Exception): allow to return custom exceptions - #1307

Merged
BotellaA merged 1 commit into
nextfrom
issue_repair_task119577
Jul 23, 2026
Merged

fix(Exception): allow to return custom exceptions#1307
BotellaA merged 1 commit into
nextfrom
issue_repair_task119577

Conversation

@BotellaA

Copy link
Copy Markdown
Member

No description provided.

@BotellaA
BotellaA requested a review from panquez July 22, 2026 09:07
@github-actions

Copy link
Copy Markdown
Contributor

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v20.1.8) reports: 8 concern(s)
  • include/geode/basic/library.hpp:130:9: warning: [cppcoreguidelines-macro-usage]

    variadic macro 'check_assertion' used; consider using a 'constexpr' variadic template function

      130 | #define check_assertion( condition, ... )                                      \
          |         ^
  • include/geode/basic/library.hpp:130:9: warning: [readability-identifier-naming]

    invalid case style for macro definition 'check_assertion'

      130 | #define check_assertion( condition, ... )                                      \
          |         ^~~~~~~~~~~~~~~
          |         CHECK_ASSERTION
  • include/geode/basic/library.hpp:139:9: warning: [cppcoreguidelines-macro-usage]

    variadic macro 'check_exception' used; consider using a 'constexpr' variadic template function

      139 | #define check_exception( condition, data, type, ... )                          \
          |         ^
  • include/geode/basic/library.hpp:139:9: warning: [readability-identifier-naming]

    invalid case style for macro definition 'check_exception'

      139 | #define check_exception( condition, data, type, ... )                          \
          |         ^~~~~~~~~~~~~~~
          |         CHECK_EXCEPTION
  • include/geode/basic/library.hpp:158:5: warning: [concurrency-mt-unsafe]

    function is not thread safe

      158 |     OPENGEODE_LIBRARY( opengeode_basic_api, OpenGeode, Basic );
          |     ^
    /__w/OpenGeode/OpenGeode/include/geode/basic/library.hpp:114:21: note: expanded from macro 'OPENGEODE_LIBRARY'
      114 |                     exit( 1 );                                                 \
          |                     ^
  • include/geode/basic/library.hpp:158:5: warning: [cppcoreguidelines-missing-std-forward]

    forwarding reference parameter 'condition' is never forwarded inside the function body

      158 |     OPENGEODE_LIBRARY( opengeode_basic_api, OpenGeode, Basic );
          |     ^
    /__w/OpenGeode/OpenGeode/include/geode/basic/library.hpp:104:25: note: expanded from macro 'OPENGEODE_LIBRARY'
      104 |             Condition&& condition, MessageProvider&& message_provider )        \
          |                         ^
  • include/geode/basic/library.hpp:158:5: warning: [cppcoreguidelines-missing-std-forward]

    forwarding reference parameter 'data_provider' is never forwarded inside the function body

      158 |     OPENGEODE_LIBRARY( opengeode_basic_api, OpenGeode, Basic );
          |     ^
    /__w/OpenGeode/OpenGeode/include/geode/basic/library.hpp:91:28: note: expanded from macro 'OPENGEODE_LIBRARY'
       91 |             DataProvider&& data_provider,                                      \
          |                            ^
  • include/geode/basic/library.hpp:158:5: warning: [cppcoreguidelines-missing-std-forward]

    forwarding reference parameter 'message_provider' is never forwarded inside the function body

      158 |     OPENGEODE_LIBRARY( opengeode_basic_api, OpenGeode, Basic );
          |     ^
    /__w/OpenGeode/OpenGeode/include/geode/basic/library.hpp:93:31: note: expanded from macro 'OPENGEODE_LIBRARY'
       93 |             MessageProvider&& message_provider )                               \
          |                               ^

Have any feedback or feature suggestions? Share it here.

@BotellaA
BotellaA merged commit 23d813f into next Jul 23, 2026
23 checks passed
@BotellaA
BotellaA deleted the issue_repair_task119577 branch July 23, 2026 07:12
@BotellaA

Copy link
Copy Markdown
Member Author

🎉 This PR is included in version 17.4.4-rc.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@BotellaA

Copy link
Copy Markdown
Member Author

🎉 This PR is included in version 17.4.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants