Skip to content

fix(Test): all tests are essential by default #1304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BotellaA merged 1 commit into from
Jul 9, 2026
Merged

fix(Test): all tests are essential by default #1304

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions cmake/CppTargets.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,13 +258,7 @@ function(add_geode_test)
TIMEOUT 300
FAIL_REGULAR_EXPRESSION "Sanitizer"
)
if(GEODE_TEST_ESSENTIAL)
add_dependencies(essential ${target_name})
set_tests_properties(${target_name}
PROPERTIES
LABELS essential
)
elseif(GEODE_TEST_UNSTABLE)
if(GEODE_TEST_UNSTABLE)
set_tests_properties(${target_name}
PROPERTIES
LABELS unstable
Expand All @@ -275,6 +269,12 @@ function(add_geode_test)
LABELS local
TIMEOUT 0
)
else()
add_dependencies(essential ${target_name})
set_tests_properties(${target_name}
PROPERTIES
LABELS essential
)
endif()
if(GEODE_TEST_FIXTURES_SETUP)
set_tests_properties(${target_name}
Expand Down
Loading