Skip to content

fix(Manifold): improve reproductibility - #190

Merged
BotellaA merged 4 commits into
nextfrom
fix/manifold-repro
Jul 23, 2026
Merged

fix(Manifold): improve reproductibility#190
BotellaA merged 4 commits into
nextfrom
fix/manifold-repro

Conversation

@BotellaA

Copy link
Copy Markdown
Member

No description provided.

@github-actions
github-actions Bot changed the base branch from master to next July 23, 2026 08:19
@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v20.1.8) reports: 2 concern(s)
  • bindings/python/src/inspection/inspection.cpp:72:1: warning: [modernize-concat-nested-namespaces]

    nested namespaces can be concatenated

       72 | namespace pybind11
          | ^~~~~~~~~~~~~~~~~~
       73 | {
          | ~
       74 |     namespace detail
          |     ~~~~~~~~~~~~~~~~
          |     namespace pybind11::detail
  • src/geode/inspector/inspection/criterion/manifold/brep_meshes_manifold.cpp:155:14: warning: [readability-function-cognitive-complexity]

    function 'add_model_non_manifold_edges' has cognitive complexity of 32 (threshold 10)

      155 |         void add_model_non_manifold_edges(
          |              ^
    /__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/manifold/brep_meshes_manifold.cpp:160:13: note: +1, including nesting penalty of 0, nesting level increased to 1
      160 |             for( const auto& surface : model().active_surfaces() )
          |             ^
    /__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/manifold/brep_meshes_manifold.cpp:163:17: note: +2, including nesting penalty of 1, nesting level increased to 2
      163 |                 for( const auto polygon_id : Range{ mesh.nb_polygons() } )
          |                 ^
    /__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/manifold/brep_meshes_manifold.cpp:166:21: note: +3, including nesting penalty of 2, nesting level increased to 3
      166 |                     for( const auto edge_id : LIndices{ vertices } )
          |                     ^
    /__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/manifold/brep_meshes_manifold.cpp:170:25: note: +4, including nesting penalty of 3, nesting level increased to 4
      170 |                         if( !adj || adj.value() < polygon_id )
          |                         ^
    /__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/manifold/brep_meshes_manifold.cpp:170:34: note: +1
      170 |                         if( !adj || adj.value() < polygon_id )
          |                                  ^
    /__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/manifold/brep_meshes_manifold.cpp:179:46: note: +4, including nesting penalty of 3, nesting level increased to 4
      179 |                                              ? 0
          |                                              ^
    /__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/manifold/brep_meshes_manifold.cpp:184:25: note: +4, including nesting penalty of 3, nesting level increased to 4
      184 |                         if( !info.second )
          |                         ^
    /__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/manifold/brep_meshes_manifold.cpp:191:13: note: +1, including nesting penalty of 0, nesting level increased to 1
      191 |             for( auto& edge : edges )
          |             ^
    /__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/manifold/brep_meshes_manifold.cpp:193:17: note: +2, including nesting penalty of 1, nesting level increased to 2
      193 |                 if( edge.second.size() <= 1 )
          |                 ^
    /__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/manifold/brep_meshes_manifold.cpp:201:17: note: +2, including nesting penalty of 1, nesting level increased to 2
      201 |                 for( const auto surface_uuid : edge.second )
          |                 ^
    /__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/manifold/brep_meshes_manifold.cpp:215:13: note: +1, including nesting penalty of 0, nesting level increased to 1
      215 |             for( const auto& line : model().active_lines() )
          |             ^
    /__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/manifold/brep_meshes_manifold.cpp:218:17: note: +2, including nesting penalty of 1, nesting level increased to 2
      218 |                 if( mesh.nb_edges() != 1
          |                 ^
    /__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/manifold/brep_meshes_manifold.cpp:219:21: note: +1
      219 |                     || model().nb_embedding_surfaces( line ) == 0 )
          |                     ^
    /__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/manifold/brep_meshes_manifold.cpp:224:17: note: +2, including nesting penalty of 1, nesting level increased to 2
      224 |                 for( const auto edge_vertex : LRange{ 2 } )
          |                 ^
    /__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/criterion/manifold/brep_meshes_manifold.cpp:230:17: note: +2, including nesting penalty of 1, nesting level increased to 2
      230 |                 if( several_cmvs_on_one_vertex( edge_unique_vertices ) )
          |                 ^

Have any feedback or feature suggestions? Share it here.

@BotellaA
BotellaA merged commit 98da91d into next Jul 23, 2026
20 checks passed
@BotellaA
BotellaA deleted the fix/manifold-repro branch July 23, 2026 11:19
@BotellaA

Copy link
Copy Markdown
Member Author

🎉 This PR is included in version 6.11.8-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@BotellaA

Copy link
Copy Markdown
Member Author

🎉 This PR is included in version 6.11.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants