fix(Tuple): remove std::make_pair and std::make_tuple by BenPinet · Pull Request #175 · Geode-solutions/OpenGeode-GeosciencesIO

BenPinet · 2026-08-06T12:10:47Z

No description provided.

github-actions · 2026-08-06T12:14:18Z

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v20.1.8) reports: 130 concern(s)

src/geode/geosciences_io/mesh/pl_output.cpp:67:30: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
   67 |             for( const auto& id : ids )
      |                              ^
```
src/geode/geosciences_io/mesh/pl_output.cpp:78:39: warning: [bugprone-unchecked-optional-access]

unchecked access to optional value
```
   78 |                     geode::to_string( attribute->name().value() ) );
      |                                       ^
```

src/geode/geosciences_io/mesh/pl_output.cpp:79:47: warning: [hicpp-use-emplace]

use emplace_back instead of push_back

   79 |                 prop_header.prop_legal_ranges.push_back(
      |                                               ^~~~~~~~~~
      |                                               emplace_back(
   80 |                     { "**none**", "**none**" } );
      |                     ~                        ~

src/geode/geosciences_io/mesh/pl_output.cpp:81:56: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   81 |                 prop_header.no_data_values.push_back( -99999. );
      |                                                        ^
```
src/geode/geosciences_io/mesh/pl_output.cpp:83:39: warning: [bugprone-unchecked-optional-access]

unchecked access to optional value
```
   83 |                     geode::to_string( attribute->name().value() ) );
      |                                       ^
```

src/geode/geosciences_io/mesh/pl_output.cpp:84:35: warning: [hicpp-use-emplace]

use emplace_back instead of push_back

   84 |                 prop_header.kinds.push_back( "Real Number" );
      |                                   ^~~~~~~~~~
      |                                   emplace_back(

src/geode/geosciences_io/mesh/pl_output.cpp:85:47: warning: [hicpp-use-emplace]

use emplace_back instead of push_back

   85 |                 prop_header.property_subclass.push_back(
      |                                               ^~~~~~~~~~
      |                                               emplace_back(
   86 |                     { "QUANTITY", "Float" } );
      |                     ~                     ~

src/geode/geosciences_io/mesh/pl_output.cpp:88:35: warning: [hicpp-use-emplace]

use emplace_back instead of push_back

   88 |                 prop_header.units.push_back( "unitless" );
      |                                   ^~~~~~~~~~
      |                                   emplace_back(

src/geode/geosciences_io/mesh/pl_output.cpp:92:39: warning: [bugprone-unchecked-optional-access]

unchecked access to optional value
```
   92 |                     geode::to_string( attribute->name().value() );
      |                                       ^
```
src/geode/geosciences_io/mesh/pl_output.cpp:101:30: warning: [readability-identifier-length]

variable name 'ch' is too short, expected at least 3 characters
```
  101 |             for( const auto& ch : prop_class_header )
      |                              ^
```

src/geode/geosciences_io/mesh/pl_output.cpp:107:14: warning: [readability-identifier-naming]

invalid case style for function 'write_XYZ_prop_class_header'

  100 |             write_XYZ_prop_class_header();
      |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |             write_xyz_prop_class_header
  101 |             for( const auto& ch : prop_class_header )
  102 |             {
  103 |                 write_property_class_header( file_, ch );
  104 |             }
  105 |         }
  106 | 
  107 |         void write_XYZ_prop_class_header()
      |              ^~~~~~~~~~~~~~~~~~~~~~~~~~~
      |              write_xyz_prop_class_header

src/geode/geosciences_io/mesh/pl_output.cpp:132:34: warning: [readability-identifier-length]

parameter name 'v' is too short, expected at least 3 characters
```
  132 |             const geode::index_t v, const geode::index_t current_offset )
      |                                  ^
```

src/geode/geosciences_io/mesh/pl_output.cpp:144:42: warning: [readability-function-cognitive-complexity]

function 'get_edged_vertex_on_iline' has cognitive complexity of 13 (threshold 10)

  144 |         std::vector< geode::EdgeVertex > get_edged_vertex_on_iline(
      |                                          ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/mesh/pl_output.cpp:151:13: note: +1, including nesting penalty of 0, nesting level increased to 1
  151 |             while( propagate )
      |             ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/mesh/pl_output.cpp:162:29: note: +1
  162 |                             && ( !edge_done_[edges_around[0].edge_id]
      |                             ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/mesh/pl_output.cpp:163:34: note: +1
  163 |                                  || !edge_done_[edges_around[1].edge_id] );
      |                                  ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/mesh/pl_output.cpp:164:17: note: +2, including nesting penalty of 1, nesting level increased to 2
  164 |                 if( propagate )
      |                 ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/mesh/pl_output.cpp:166:21: note: +3, including nesting penalty of 2, nesting level increased to 3
  166 |                     for( const auto& edge : edges_around )
      |                     ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/mesh/pl_output.cpp:168:25: note: +4, including nesting penalty of 3, nesting level increased to 4
  168 |                         if( edge_done_[edge.edge_id] )
      |                         ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/mesh/pl_output.cpp:175:22: note: +1, nesting level increased to 2
  175 |                 else if( edges_around.size() != 2 )
      |                      ^

src/geode/geosciences_io/mesh/pl_output.cpp:145:38: warning: [readability-identifier-length]

parameter name 'ev' is too short, expected at least 3 characters
```
  145 |             const geode::EdgeVertex& ev )
      |                                      ^
```

src/geode/geosciences_io/mesh/pl_output.cpp:153:17: warning: [clang-analyzer-deadcode.DeadStores]

Value stored to 'propagate' is never read

  153 |                 propagate = false;
      |                 ^           ~~~~~
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/mesh/pl_output.cpp:153:17: note: Value stored to 'propagate' is never read
  153 |                 propagate = false;
      |                 ^           ~~~~~

src/geode/geosciences_io/mesh/pl_output.cpp:234:13: warning: [bugprone-easily-swappable-parameters]

2 adjacent parameters of 'write_edge_and_vertex' of similar type ('geode::index_t &') are easily swapped by mistake

  234 |             geode::index_t& current_offset,
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  235 |             geode::index_t& nb_edges_done )
      |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/mesh/pl_output.cpp:234:29: note: the first parameter in the range is 'current_offset'
  234 |             geode::index_t& current_offset,
      |                             ^~~~~~~~~~~~~~
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/mesh/pl_output.cpp:235:29: note: the last parameter in the range is 'nb_edges_done'
  235 |             geode::index_t& nb_edges_done )
      |                             ^~~~~~~~~~~~~

src/geode/geosciences_io/mesh/pl_output.cpp:240:30: warning: [readability-identifier-length]

variable name 'ev' is too short, expected at least 3 characters
```
  240 |             for( const auto& ev : ev_on_iline )
      |                              ^
```
src/geode/geosciences_io/mesh/pl_output.cpp:266:13: warning: [readability-redundant-control-flow]

redundant return statement at the end of a function with a void return type
```
  266 |             return;
      |             ^~~~~~~
  267 |         }
```

src/geode/geosciences_io/mesh/pl_output.cpp:274:21: warning: [readability-identifier-naming]

invalid case style for private member 'VRTX_KEYWORD'

   69 |         std::string VRTX_KEYWORD{ "VRTX" };
      |                     ^~~~~~~~~~~~
      |                     VRTX_KEYWORD_

src/geode/geosciences_io/mesh/pl_output.cpp:278:1: warning: [modernize-concat-nested-namespaces]

nested namespaces can be concatenated

  278 | namespace geode
      | ^~~~~~~~~~~~~~~
  279 | {
      | ~
  280 |     namespace internal
      |     ~~~~~~~~~~~~~~~~~~
      |     namespace geode::internal
  281 |     {
  282 |         std::vector< std::string > PLOutput::write(
  283 |             const EdgedCurve3D& edged_curve ) const
  284 |         {
  285 |             PLOutputImpl impl{ filename(), edged_curve };
  286 |             impl.write_file();
  287 |             return { to_string( filename() ) };
  288 |         }
  289 |     } // namespace internal
      |     ~~~~~~~~~~~~~~~~~~~~~~~
      |     } // namespace geode::internal
  290 | } // namespace geode
      | ~~~~~~~~~~~~~~~~~~~~

src/geode/geosciences_io/mesh/ts_output.cpp:44:41: warning: [clang-diagnostic-unused-const-variable]

unused variable 'OFFSET_START'

   44 |         static constexpr geode::index_t OFFSET_START{ 1 };
      |                                         ^~~~~~~~~~~~

src/geode/geosciences_io/mesh/ts_output.cpp:83:30: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
   83 |             for( const auto& id : ids )
      |                              ^
```
src/geode/geosciences_io/mesh/ts_output.cpp:90:24: warning: [bugprone-unchecked-optional-access]

unchecked access to optional value
```
   90 |                     || attribute->name().value() == "points" )
      |                        ^
```
src/geode/geosciences_io/mesh/ts_output.cpp:96:39: warning: [bugprone-unchecked-optional-access]

unchecked access to optional value
```
   96 |                     geode::to_string( attribute->name().value() ) );
      |                                       ^
```

src/geode/geosciences_io/mesh/ts_output.cpp:97:47: warning: [hicpp-use-emplace]

use emplace_back instead of push_back

   97 |                 prop_header.prop_legal_ranges.push_back(
      |                                               ^~~~~~~~~~
      |                                               emplace_back(
   98 |                     { "**none**", "**none**" } );
      |                     ~                        ~

src/geode/geosciences_io/mesh/ts_output.cpp:99:56: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   99 |                 prop_header.no_data_values.push_back( -99999. );
      |                                                        ^
```
src/geode/geosciences_io/mesh/ts_output.cpp:101:39: warning: [bugprone-unchecked-optional-access]

unchecked access to optional value
```
  101 |                     geode::to_string( attribute->name().value() ) );
      |                                       ^
```

src/geode/geosciences_io/mesh/ts_output.cpp:102:35: warning: [hicpp-use-emplace]

use emplace_back instead of push_back

  102 |                 prop_header.kinds.push_back( "Real Number" );
      |                                   ^~~~~~~~~~
      |                                   emplace_back(

src/geode/geosciences_io/mesh/ts_output.cpp:103:47: warning: [hicpp-use-emplace]

use emplace_back instead of push_back

  103 |                 prop_header.property_subclass.push_back(
      |                                               ^~~~~~~~~~
      |                                               emplace_back(
  104 |                     { "QUANTITY", "Float" } );
      |                     ~                     ~

src/geode/geosciences_io/mesh/ts_output.cpp:106:35: warning: [hicpp-use-emplace]

use emplace_back instead of push_back

  106 |                 prop_header.units.push_back( "unitless" );
      |                                   ^~~~~~~~~~
      |                                   emplace_back(

src/geode/geosciences_io/mesh/ts_output.cpp:110:39: warning: [bugprone-unchecked-optional-access]

unchecked access to optional value
```
  110 |                     geode::to_string( attribute->name().value() );
      |                                       ^
```

src/geode/geosciences_io/mesh/ts_output.cpp:185:76: warning: [readability-redundant-member-init]

initializer for member 'generic_att_' is redundant

  185 |         std::vector< std::shared_ptr< geode::AttributeBase > > generic_att_{};
      |                                                                            ^~

src/geode/geosciences_io/mesh/ts_output.cpp:186:21: warning: [readability-identifier-naming]

invalid case style for private member 'VRTX_KEYWORD'

   85 |         std::string VRTX_KEYWORD{ "VRTX" };
      |                     ^~~~~~~~~~~~
      |                     VRTX_KEYWORD_

src/geode/geosciences_io/mesh/ts_output.cpp:190:1: warning: [modernize-concat-nested-namespaces]

nested namespaces can be concatenated

  190 | namespace geode
      | ^~~~~~~~~~~~~~~
  191 | {
      | ~
  192 |     namespace internal
      |     ~~~~~~~~~~~~~~~~~~
      |     namespace geode::internal
  193 |     {
  194 |         std::vector< std::string > TSOutput::write(
  195 |             const TriangulatedSurface3D& surface ) const
  196 |         {
  197 |             TSOutputImpl impl{ filename(), surface };
  198 |             impl.write_file();
  199 |             return { to_string( filename() ) };
  200 |         }
  201 |     } // namespace internal
      |     ~~~~~~~~~~~~~~~~~~~~~~~
      |     } // namespace geode::internal
  202 | } // namespace geode
      | ~~~~~~~~~~~~~~~~~~~~

src/geode/geosciences_io/mesh/vs_output.cpp:44:41: warning: [clang-diagnostic-unused-const-variable]

unused variable 'OFFSET_START'

   44 |         static constexpr geode::index_t OFFSET_START{ 1 };
      |                                         ^~~~~~~~~~~~

src/geode/geosciences_io/mesh/vs_output.cpp:87:30: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
   87 |             for( const auto& id : ids )
      |                              ^
```
src/geode/geosciences_io/mesh/vs_output.cpp:93:24: warning: [bugprone-unchecked-optional-access]

unchecked access to optional value
```
   93 |                     || attribute->name().value() == "points" )
      |                        ^
```
src/geode/geosciences_io/mesh/vs_output.cpp:99:39: warning: [bugprone-unchecked-optional-access]

unchecked access to optional value
```
   99 |                     geode::to_string( attribute->name().value() ) );
      |                                       ^
```

src/geode/geosciences_io/mesh/vs_output.cpp:100:47: warning: [hicpp-use-emplace]

use emplace_back instead of push_back

  100 |                 prop_header.prop_legal_ranges.push_back(
      |                                               ^~~~~~~~~~
      |                                               emplace_back(
  101 |                     { "**none**", "**none**" } );
      |                     ~                        ~

src/geode/geosciences_io/mesh/vs_output.cpp:102:56: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
  102 |                 prop_header.no_data_values.push_back( -99999. );
      |                                                        ^
```
src/geode/geosciences_io/mesh/vs_output.cpp:104:39: warning: [bugprone-unchecked-optional-access]

unchecked access to optional value
```
  104 |                     geode::to_string( attribute->name().value() ) );
      |                                       ^
```

src/geode/geosciences_io/mesh/vs_output.cpp:105:35: warning: [hicpp-use-emplace]

use emplace_back instead of push_back

  105 |                 prop_header.kinds.push_back( "Real Number" );
      |                                   ^~~~~~~~~~
      |                                   emplace_back(

src/geode/geosciences_io/mesh/vs_output.cpp:106:47: warning: [hicpp-use-emplace]

use emplace_back instead of push_back

  106 |                 prop_header.property_subclass.push_back(
      |                                               ^~~~~~~~~~
      |                                               emplace_back(
  107 |                     { "QUANTITY", "Float" } );
      |                     ~                     ~

src/geode/geosciences_io/mesh/vs_output.cpp:109:35: warning: [hicpp-use-emplace]

use emplace_back instead of push_back

  109 |                 prop_header.units.push_back( "unitless" );
      |                                   ^~~~~~~~~~
      |                                   emplace_back(

src/geode/geosciences_io/mesh/vs_output.cpp:113:39: warning: [bugprone-unchecked-optional-access]

unchecked access to optional value
```
  113 |                     geode::to_string( attribute->name().value() );
      |                                       ^
```

src/geode/geosciences_io/mesh/vs_output.cpp:174:76: warning: [readability-redundant-member-init]

initializer for member 'generic_att_' is redundant

  174 |         std::vector< std::shared_ptr< geode::AttributeBase > > generic_att_{};
      |                                                                            ^~

src/geode/geosciences_io/mesh/vs_output.cpp:175:21: warning: [readability-identifier-naming]

invalid case style for private member 'VRTX_KEYWORD'

   84 |             file_ << VRTX_KEYWORD << SPACE << vertex_id << SPACE
      |                      ~~~~~~~~~~~~
      |                      VRTX_KEYWORD_
   85 |                   << pointset_.point( vertex_id ).string();
   86 |             for( const auto& att : generic_att_ )
   87 |             {
   88 |                 file_ << SPACE << att->generic_value( vertex_id );
   89 |             }
   90 |             file_ << EOL;
   91 |         }
   92 | 
   93 |     private:
   94 |         std::ofstream file_;
   95 |         const geode::PointSet3D& pointset_;
   96 |         std::vector< std::shared_ptr< geode::AttributeBase > > generic_att_{};
   97 |         std::string VRTX_KEYWORD{ "VRTX" };
      |                     ^~~~~~~~~~~~
      |                     VRTX_KEYWORD_

src/geode/geosciences_io/mesh/vs_output.cpp:179:1: warning: [modernize-concat-nested-namespaces]

nested namespaces can be concatenated

  179 | namespace geode
      | ^~~~~~~~~~~~~~~
  180 | {
      | ~
  181 |     namespace internal
      |     ~~~~~~~~~~~~~~~~~~
      |     namespace geode::internal
  182 |     {
  183 |         std::vector< std::string > VSOutput::write(
  184 |             const PointSet3D& pointset ) const
  185 |         {
  186 |             VSOutputImpl impl{ filename(), pointset };
  187 |             impl.write_file();
  188 |             return { to_string( filename() ) };
  189 |         }
  190 |     } // namespace internal
      |     ~~~~~~~~~~~~~~~~~~~~~~~
      |     } // namespace geode::internal
  191 | } // namespace geode
      | ~~~~~~~~~~~~~~~~~~~~

src/geode/geosciences_io/model/internal/gocad_common.cpp:42:27: warning: [clang-diagnostic-unused-const-variable]

unused variable 'EOL'
```
   42 |     static constexpr char EOL{ '\n' };
      |                           ^~~
```
src/geode/geosciences_io/model/internal/gocad_common.cpp:42:27: warning: [readability-static-definition-in-anonymous-namespace]

'EOL' is a static definition in anonymous namespace; static is redundant here
```
   42 |     static constexpr char EOL{ '\n' };
      |     ~~~~~~                ^
```
src/geode/geosciences_io/model/internal/gocad_common.cpp:43:27: warning: [clang-diagnostic-unused-const-variable]

unused variable 'SPACE'
```
   43 |     static constexpr char SPACE{ ' ' };
      |                           ^~~~~
```
src/geode/geosciences_io/model/internal/gocad_common.cpp:43:27: warning: [readability-static-definition-in-anonymous-namespace]

'SPACE' is a static definition in anonymous namespace; static is redundant here
```
   43 |     static constexpr char SPACE{ ' ' };
      |     ~~~~~~                ^
```

src/geode/geosciences_io/model/internal/gocad_common.cpp:48:17: warning: [readability-function-cognitive-complexity]

function 'determine_paired_signs' has cognitive complexity of 35 (threshold 10)

   48 |     PairedSigns determine_paired_signs( const geode::BRep& brep )
      |                 ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/gocad_common.cpp:52:9: note: +1, including nesting penalty of 0, nesting level increased to 1
   52 |         for( const auto& line : brep.lines() )
      |         ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/gocad_common.cpp:64:13: note: +2, including nesting penalty of 1, nesting level increased to 2
   64 |             for( const auto& cmv0 : cmvs0 )
      |             ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/gocad_common.cpp:66:17: note: +3, including nesting penalty of 2, nesting level increased to 3
   66 |                 if( cmv0.component_id.type()
      |                 ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/gocad_common.cpp:71:17: note: +3, including nesting penalty of 2, nesting level increased to 3
   71 |                 for( const auto& cmv1 : cmvs1 )
      |                 ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/gocad_common.cpp:73:21: note: +4, including nesting penalty of 3, nesting level increased to 4
   73 |                     if( cmv1.component_id.type()
      |                     ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/gocad_common.cpp:78:21: note: +4, including nesting penalty of 3, nesting level increased to 4
   78 |                     if( cmv1.component_id.id() != cmv0.component_id.id() )
      |                     ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/gocad_common.cpp:89:21: note: +4, including nesting penalty of 3, nesting level increased to 4
   89 |                     if( v0v1 && !v1v0 )
      |                     ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/gocad_common.cpp:89:30: note: +1
   89 |                     if( v0v1 && !v1v0 )
      |                              ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/gocad_common.cpp:93:26: note: +1, nesting level increased to 4
   93 |                     else if( v1v0 && !v0v1 )
      |                          ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/gocad_common.cpp:93:35: note: +1
   93 |                     else if( v1v0 && !v0v1 )
      |                                   ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/gocad_common.cpp:99:13: note: +2, including nesting penalty of 1, nesting level increased to 2
   99 |             if( surface_direct_edges.size() < 2 )
      |             ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/gocad_common.cpp:103:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  103 |             for( const auto& s0 : surface_direct_edges )
      |             ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/gocad_common.cpp:105:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  105 |                 for( const auto& s1 : surface_direct_edges )
      |                 ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/gocad_common.cpp:107:21: note: +4, including nesting penalty of 3, nesting level increased to 4
  107 |                     if( s0.first < s1.first )
      |                     ^

src/geode/geosciences_io/model/internal/gocad_common.cpp:51:31: warning: [bugprone-implicit-widening-of-multiplication-result]

performing an implicit widening conversion to type 'size_t' (aka 'unsigned long') of a multiplication performed in type 'index_t' (aka 'unsigned int')

   51 |         paired_signs.reserve( brep.nb_lines() * 2 );
      |                               ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/gocad_common.cpp:51:31: note: make conversion explicit to silence this warning
   24 |         paired_signs.reserve( brep.nb_lines() * 2 );
      |                               ^~~~~~~~~~~~~~~~~~~
      |                               static_cast<size_t>( )
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/gocad_common.cpp:51:31: note: perform multiplication in a wider type
   51 |         paired_signs.reserve( brep.nb_lines() * 2 );
      |                               ^~~~~~~~~~~~~~~
      |                               static_cast<size_t>( )

src/geode/geosciences_io/model/internal/gocad_common.cpp:103:30: warning: [readability-identifier-length]

variable name 's0' is too short, expected at least 3 characters
```
  103 |             for( const auto& s0 : surface_direct_edges )
      |                              ^
```
src/geode/geosciences_io/model/internal/gocad_common.cpp:105:34: warning: [readability-identifier-length]

variable name 's1' is too short, expected at least 3 characters
```
  105 |                 for( const auto& s1 : surface_direct_edges )
      |                                  ^
```

src/geode/geosciences_io/model/internal/gocad_common.cpp:120:30: warning: [readability-function-cognitive-complexity]

function 'determine_relative_signs' has cognitive complexity of 13 (threshold 10)

  120 |     absl::FixedArray< bool > determine_relative_signs(
      |                              ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/gocad_common.cpp:125:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  125 |         if( nb_surfaces == 1 )
      |         ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/gocad_common.cpp:134:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  134 |         while( !to_process.empty() )
      |         ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/gocad_common.cpp:139:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  139 |             for( const auto s : geode::Range{ nb_surfaces } )
      |             ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/gocad_common.cpp:141:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  141 |                 if( determined[s] )
      |                 ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/gocad_common.cpp:149:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  149 |                 if( itr == paired_signs.end() )
      |                 ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/gocad_common.cpp:154:33: note: +3, including nesting penalty of 2, nesting level increased to 3
  154 |                     itr->second ? signs[determined_s] : !signs[determined_s];
      |                                 ^

src/geode/geosciences_io/model/internal/gocad_common.cpp:139:29: warning: [readability-identifier-length]

variable name 's' is too short, expected at least 3 characters
```
  139 |             for( const auto s : geode::Range{ nb_surfaces } )
      |                             ^
```
src/geode/geosciences_io/model/internal/gocad_common.cpp:175:25: warning: [readability-identifier-length]

variable name 's' is too short, expected at least 3 characters
```
  175 |         for( const auto s : geode::Indices{ universe_boundaries } )
      |                         ^
```

src/geode/geosciences_io/model/internal/gocad_common.cpp:208:38: warning: [bugprone-implicit-widening-of-multiplication-result]

performing an implicit widening conversion to type 'size_type' (aka 'unsigned long') of a multiplication performed in type 'index_t' (aka 'unsigned int')

  208 |         universe_boundaries.reserve( 2 * brep.nb_model_boundaries() );
      |                                      ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/gocad_common.cpp:208:38: note: make conversion explicit to silence this warning
  208 |         universe_boundaries.reserve( 2 * brep.nb_model_boundaries() );
      |                                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                      static_cast<size_type>(       )
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/gocad_common.cpp:208:38: note: perform multiplication in a wider type
  208 |         universe_boundaries.reserve( 2 * brep.nb_model_boundaries() );
      |                                      ^
      |                                      static_cast<size_type>( )

src/geode/geosciences_io/model/internal/gocad_common.cpp:223:25: warning: [readability-identifier-length]

variable name 'b' is too short, expected at least 3 characters
```
  223 |         for( const auto b : geode::Indices{ universe_boundaries } )
      |                         ^
```
src/geode/geosciences_io/model/internal/gocad_common.cpp:248:29: warning: [readability-identifier-length]

variable name 'b' is too short, expected at least 3 characters
```
  248 |             for( const auto b : geode::Indices{ block_boundaries } )
      |                             ^
```

src/geode/geosciences_io/model/internal/gocad_common.cpp:260:1: warning: [modernize-concat-nested-namespaces]

nested namespaces can be concatenated

  260 | namespace geode
      | ^~~~~~~~~~~~~~~
  261 | {
      | ~
  262 |     namespace internal
      |     ~~~~~~~~~~~~~~~~~~
      |     namespace geode::internal

src/geode/geosciences_io/model/internal/lso_input.cpp:62:11: warning: [cppcoreguidelines-special-member-functions]

class 'LSOInputImpl' defines a non-default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator
```
   62 |     class LSOInputImpl
      |           ^
```
src/geode/geosciences_io/model/internal/lso_input.cpp:66:31: warning: [clang-diagnostic-unused-const-variable]

unused variable 'EOL'
```
   66 |         static constexpr char EOL{ '\n' };
      |                               ^~~
```

src/geode/geosciences_io/model/internal/lso_input.cpp:80:13: warning: [cppcoreguidelines-pro-type-member-init]

uninitialized record type: 'vertex_attribute_values'

   80 |             geode::AttributeValues< geode::index_t > vertex_attribute_values;
      |             ^                                                               
      |                                                                             {}

src/geode/geosciences_io/model/internal/lso_input.cpp:179:13: warning: [cppcoreguidelines-avoid-do-while]

avoid do-while loops
```
  179 |             do
      |             ^
```

src/geode/geosciences_io/model/internal/lso_input.cpp:182:32: warning: [cppcoreguidelines-init-variables]

variable 'unique_id' is not initialized

  182 |                 geode::index_t unique_id;
      |                                ^        
      |                                          = 0

src/geode/geosciences_io/model/internal/lso_input.cpp:194:61: warning: [cppcoreguidelines-avoid-magic-numbers]

5 is a magic number; consider replacing it with a named constant
```
  194 |                         vertices_attributes_, get_tokens(), 5 );
      |                                                             ^
```
src/geode/geosciences_io/model/internal/lso_input.cpp:198:28: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  198 |                 const auto id = solid_builder_->create_point( point );
      |                            ^
```
src/geode/geosciences_io/model/internal/lso_input.cpp:240:13: warning: [cppcoreguidelines-avoid-do-while]

avoid do-while loops
```
  240 |             do
      |             ^
```

src/geode/geosciences_io/model/internal/lso_input.cpp:243:17: warning: [cppcoreguidelines-pro-type-member-init]

uninitialized record type: 'vertices'

  243 |                 std::array< geode::index_t, 4 > vertices;
      |                 ^                                       
      |                                                         {}

src/geode/geosciences_io/model/internal/lso_input.cpp:252:53: warning: [cppcoreguidelines-avoid-magic-numbers]

5 is a magic number; consider replacing it with a named constant
```
  252 |                     tetrahedra_attributes_, tokens, 5 );
      |                                                     ^
```
src/geode/geosciences_io/model/internal/lso_input.cpp:297:28: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  297 |                 const auto id =
      |                            ^
```

src/geode/geosciences_io/model/internal/lso_input.cpp:302:48: warning: [bugprone-unchecked-optional-access]

unchecked access to optional value

  302 |                 builder_.set_surface_name( id, horizon.name().value() );
      |                                                ^

src/geode/geosciences_io/model/internal/lso_input.cpp:308:14: warning: [readability-function-cognitive-complexity]

function 'read_triangles' has cognitive complexity of 12 (threshold 10)

  308 |         void read_triangles( const geode::uuid& surface_id )
      |              ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/lso_input.cpp:317:13: note: +1, including nesting penalty of 0, nesting level increased to 1
  317 |             while( std::getline( file_, line_ )
      |             ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/lso_input.cpp:318:20: note: +1
  318 |                    && geode::string_starts_with( line_, "TRGL" ) )
      |                    ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/lso_input.cpp:323:17: note: +2, including nesting penalty of 1, nesting level increased to 2
  323 |                 for( const auto i : geode::LRange{ 3 } )
      |                 ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/lso_input.cpp:329:21: note: +3, including nesting penalty of 2, nesting level increased to 3
  329 |                     if( it != vertex_mapping.end() )
      |                     ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/lso_input.cpp:333:21: note: +1, nesting level increased to 3
  333 |                     else
      |                     ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/lso_input.cpp:346:17: note: +2, including nesting penalty of 1, nesting level increased to 2
  346 |                 for( const auto& facet : solid_facets )
      |                 ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/lso_input.cpp:350:17: note: +2, including nesting penalty of 1, nesting level increased to 2
  350 |                 if( solid_facets.empty() )
      |                 ^

src/geode/geosciences_io/model/internal/lso_input.cpp:321:17: warning: [cppcoreguidelines-pro-type-member-init]

uninitialized record type: 'facet_vertices'

  321 |                 std::array< geode::index_t, 3 > facet_vertices;
      |                 ^                                             
      |                                                               {}

src/geode/geosciences_io/model/internal/lso_input.cpp:322:17: warning: [cppcoreguidelines-pro-type-member-init]

uninitialized record type: 'vertices'

  322 |                 std::array< geode::index_t, 3 > vertices;
      |                 ^                                       
      |                                                         {}

src/geode/geosciences_io/model/internal/lso_input.cpp:328:32: warning: [readability-identifier-length]

variable name 'it' is too short, expected at least 3 characters
```
  328 |                     const auto it = vertex_mapping.find( value );
      |                                ^
```
src/geode/geosciences_io/model/internal/lso_input.cpp:367:29: warning: [readability-identifier-length]

variable name 'v0' is too short, expected at least 3 characters
```
  367 |             for( const auto v0 : vertex_mapping_[vertices[0]] )
      |                             ^
```
src/geode/geosciences_io/model/internal/lso_input.cpp:369:33: warning: [readability-identifier-length]

variable name 'v1' is too short, expected at least 3 characters
```
  369 |                 for( const auto v1 : vertex_mapping_[vertices[1]] )
      |                                 ^
```
src/geode/geosciences_io/model/internal/lso_input.cpp:371:37: warning: [readability-identifier-length]

variable name 'v2' is too short, expected at least 3 characters
```
  371 |                     for( const auto v2 : vertex_mapping_[vertices[2]] )
      |                                     ^
```

src/geode/geosciences_io/model/internal/lso_input.cpp:417:17: warning: [cppcoreguidelines-pro-type-member-init]

uninitialized record type: 'vertices'

  417 |                 std::array< geode::index_t, 4 > vertices;
      |                 ^                                       
      |                                                         {}

src/geode/geosciences_io/model/internal/lso_input.cpp:422:32: warning: [readability-identifier-length]

variable name 'it' is too short, expected at least 3 characters
```
  422 |                     const auto it = vertex_mapping.find( vertex );
      |                                ^
```

src/geode/geosciences_io/model/internal/lso_input.cpp:452:60: warning: [readability-function-cognitive-complexity]

function 'find_block_relations' has cognitive complexity of 12 (threshold 10)

  452 |         absl::flat_hash_map< geode::uuid, geode::index_t > find_block_relations(
      |                                                            ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/lso_input.cpp:458:13: note: +1, including nesting penalty of 0, nesting level increased to 1
  458 |             for( const auto tetra : geode::Range{ solid_->nb_polyhedra() } )
      |             ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/lso_input.cpp:460:17: note: +2, including nesting penalty of 1, nesting level increased to 2
  460 |                 if( block_name_attribute_->value( tetra ) != block_name )
      |                 ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/lso_input.cpp:464:17: note: +2, including nesting penalty of 1, nesting level increased to 2
  464 |                 for( const auto f : geode::LRange{ 4 } )
      |                 ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/lso_input.cpp:469:21: note: +3, including nesting penalty of 2, nesting level increased to 3
  469 |                     if( facet_uuid == default_id_ )
      |                     ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/lso_input.cpp:474:21: note: +3, including nesting penalty of 2, nesting level increased to 3
  474 |                     if( it != surface_relations.end() )
      |                     ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/lso_input.cpp:478:21: note: +1, nesting level increased to 3
  478 |                     else
      |                     ^

src/geode/geosciences_io/model/internal/lso_input.cpp:468:64: warning: [bugprone-unchecked-optional-access]

unchecked access to optional value

  468 |                     const auto& facet_uuid = facet_id_->value( facet.value() );
      |                                                                ^

src/geode/geosciences_io/model/internal/lso_input.cpp:473:32: warning: [readability-identifier-length]

variable name 'it' is too short, expected at least 3 characters
```
  473 |                     const auto it = surface_relations.find( facet_uuid );
      |                                ^
```
src/geode/geosciences_io/model/internal/lso_input.cpp:509:25: warning: [bugprone-unchecked-optional-access]

unchecked access to optional value
```
  509 |                         block.name().value(), " is not conformal to surface ",
      |                         ^
```
src/geode/geosciences_io/model/internal/lso_input.cpp:510:25: warning: [bugprone-unchecked-optional-access]

unchecked access to optional value
```
  510 |                         surface.name().value(), "." );
      |                         ^
```

src/geode/geosciences_io/model/internal/lso_input.cpp:601:73: warning: [readability-identifier-length]

parameter name 'id' is too short, expected at least 3 characters

  601 |         void create_corner( const geode::Point3D& point, geode::index_t id )
      |                                                                         ^

src/geode/geosciences_io/model/internal/lso_input.cpp:619:14: warning: [readability-function-cognitive-complexity]

function 'build_lines' has cognitive complexity of 20 (threshold 10)

  619 |         void build_lines()
      |              ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/lso_input.cpp:621:13: note: +1, including nesting penalty of 0, nesting level increased to 1
  621 |             for( const auto& surface : model_.surfaces() )
      |             ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/lso_input.cpp:626:17: note: +2, including nesting penalty of 1, nesting level increased to 2
  626 |                 for( const auto p : geode::Range{ mesh.nb_polygons() } )
      |                 ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/lso_input.cpp:628:21: note: +3, including nesting penalty of 2, nesting level increased to 3
  628 |                     for( const auto& border :
      |                     ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/lso_input.cpp:635:25: note: +4, including nesting penalty of 3, nesting level increased to 4
  635 |                         if( !model_.has_component_mesh_vertices( unique_id0,
      |                         ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/lso_input.cpp:644:25: note: +4, including nesting penalty of 3, nesting level increased to 4
  644 |                         if( const auto line_id =
      |                         ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/lso_input.cpp:649:29: note: +5, including nesting penalty of 4, nesting level increased to 5
  649 |                             if( it != line_relations.end() )
      |                             ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/lso_input.cpp:653:29: note: +1, nesting level increased to 5
  653 |                             else
      |                             ^

src/geode/geosciences_io/model/internal/lso_input.cpp:647:40: warning: [readability-identifier-length]

variable name 'it' is too short, expected at least 3 characters
```
  647 |                             const auto it =
      |                                        ^
```

src/geode/geosciences_io/model/internal/lso_input.cpp:705:18: warning: [clang-analyzer-deadcode.DeadStores]

Value stored to 'unique_id' during its initialization is never read

  705 |             auto unique_id = unique_id0;
      |                  ^~~~~~~~~   ~~~~~~~~~~
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/lso_input.cpp:705:18: note: Value stored to 'unique_id' during its initialization is never read
  705 |             auto unique_id = unique_id0;
      |                  ^~~~~~~~~   ~~~~~~~~~~

src/geode/geosciences_io/model/internal/lso_input.cpp:707:13: warning: [cppcoreguidelines-avoid-do-while]

avoid do-while loops
```
  707 |             do
      |             ^
```

src/geode/geosciences_io/model/internal/lso_input.cpp:738:38: warning: [readability-function-cognitive-complexity]

function 'common_line' has cognitive complexity of 12 (threshold 10)

  738 |         std::optional< geode::uuid > common_line(
      |                                      ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/lso_input.cpp:741:13: note: +1, including nesting penalty of 0, nesting level increased to 1
  741 |             for( const auto& cmv0 :
      |             ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/lso_input.cpp:744:17: note: +2, including nesting penalty of 1, nesting level increased to 2
  744 |                 if( cmv0.component_id.type()
      |                 ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/lso_input.cpp:749:17: note: +2, including nesting penalty of 1, nesting level increased to 2
  749 |                 for( const auto& cmv1 :
      |                 ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/lso_input.cpp:752:21: note: +3, including nesting penalty of 2, nesting level increased to 3
  752 |                     if( cmv0.component_id == cmv1.component_id )
      |                     ^
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/src/geode/geosciences_io/model/internal/lso_input.cpp:756:25: note: +4, including nesting penalty of 3, nesting level increased to 4
  756 |                         if( max - min == 1 )
      |                         ^

src/geode/geosciences_io/model/internal/lso_input.cpp:820:1: warning: [modernize-concat-nested-namespaces]

nested namespaces can be concatenated

  820 | namespace geode
      | ^~~~~~~~~~~~~~~
  821 | {
      | ~
  822 |     namespace internal
      |     ~~~~~~~~~~~~~~~~~~
      |     namespace geode::internal

src/geode/geosciences_io/model/internal/ml_input.cpp:61:58: warning: [readability-identifier-length]

parameter name 'v0' is too short, expected at least 3 characters

   61 |         const geode::SurfaceMesh3D& mesh, geode::index_t v0, geode::index_t v1 )
      |                                                          ^

src/geode/geosciences_io/model/internal/ml_input.cpp:61:77: warning: [readability-identifier-length]

parameter name 'v1' is too short, expected at least 3 characters

   61 |         const geode::SurfaceMesh3D& mesh, geode::index_t v0, geode::index_t v1 )
      |                                                                             ^

src/geode/geosciences_io/model/internal/ml_input.cpp:84:31: warning: [clang-diagnostic-unused-const-variable]

unused variable 'EOL'
```
   84 |         static constexpr char EOL{ '\n' };
      |                               ^~~
```
src/geode/geosciences_io/model/internal/ml_input.cpp:86:9: warning: [cppcoreguidelines-pro-type-member-init]

constructor does not initialize these fields: epsilon_
```
   86 |         MLInputImpl( std::string_view filename, geode::StructuralModel& model )
      |         ^
```
src/geode/geosciences_io/model/internal/ml_input.cpp:113:30: warning: [bugprone-unchecked-optional-access]

unchecked access to optional value
```
  113 |                 tsurf.data = geode::internal::read_tsurf( file_ ).value();
      |                              ^
```
src/geode/geosciences_io/model/internal/ml_input.cpp:124:13: warning: [google-explicit-constructor]

single-argument constructors must be marked explicit to avoid unintentional implicit conversions
```
  124 |             TSurfMLData( std::string input_name )
      |             ^
      |             explicit 
```
src/geode/geosciences_io/model/internal/ml_input.cpp:159:17: warning: [cppcoreguidelines-avoid-magic-numbers]

1e-7 is a magic number; consider replacing it with a named constant
```
  159 |                 1e-7
      |                 ^
```

src/geode/geosciences_io/model/internal/ml_input.cpp:160:19: warning: [modernize-min-max-use-initializer-list]

do not use nested 'std::min' calls, use an initializer list instead

   24 |                 * std::min( diagonal.value( 0 ),
      |                   ^
      |                             {
   25 |                     std::min( diagonal.value( 1 ), diagonal.value( 2 ) ) );
      |                     ~~~~~~~~~                                          ~
      |                                                                        }

src/geode/geosciences_io/model/internal/ml_input.cpp:208:21: warning: [hicpp-move-const-arg]

passing result of std::move() as a const reference argument; no move will actually happen

  208 |                     std::move( corner_surface_index[i] ),
      |                     ^~~~~~~~~~                         ~
/__w/OpenGeode-GeosciencesIO/OpenGeode-GeosciencesIO/OpenGeode-0.0.0-ubuntu/include/geode/model/mixin/core/vertex_identifier.hpp:50:32: note: 'ComponentMeshVertex' is not move assignable/constructible
   50 |     struct opengeode_model_api ComponentMeshVertex
      |                                ^

src/geode/geosciences_io/model/internal/ml_input.cpp:421:24: warning: [readability-identifier-length]

variable name 'it' is too short, expected at least 3 characters
```
  421 |             const auto it =
      |                        ^
```
src/geode/geosciences_io/model/internal/ml_input.cpp:524:18: warning: [readability-identifier-length]

variable name 'it' is too short, expected at least 3 characters
```
  524 |             auto it = corners2line_.try_emplace(
      |                  ^
```
src/geode/geosciences_io/model/internal/ml_input.cpp:629:18: warning: [cppcoreguidelines-init-variables]

variable 'orientation' is not initialized
```
  629 |             bool orientation;
      |                  ^          
      |                              = false
```

src/geode/geosciences_io/model/internal/ml_input.cpp:728:21: warning: [abseil-string-find-str-contains]

use absl::StrContains instead of find() != npos

   57 |                 if( tsurf.feature.find( "fault" ) != std::string::npos )
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                     absl::StrContains(tsurf.feature, "fault")

Have any feedback or feature suggestions? Share it here.

fix(Tuple): remove std::make_pair and std::make_tuple

b439fef

BenPinet requested a review from BotellaA August 6, 2026 12:10

BotellaA approved these changes Aug 6, 2026

View reviewed changes

Navigation Menu

Uh oh!

Uh oh!

fix(Tuple): remove std::make_pair and std::make_tuple - #175

fix(Tuple): remove std::make_pair and std::make_tuple#175
BenPinet wants to merge 1 commit into
v18from
fix/remove_make_pair_and_tuple

BenPinet commented Aug 6, 2026

Uh oh!

github-actions Bot commented Aug 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

BenPinet commented Aug 6, 2026

Uh oh!

github-actions Bot commented Aug 6, 2026

Cpp-Linter Report ⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants