Conversation
MiniCodeMonkey
approved these changes
Jul 14, 2026
This was referenced Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24 - batch geocoding raised
IndexErrorwhen a query returned no matches (e.g. an unparseable address). The API returns one entry per query, and unmatched ones have an emptyresultslist, but the parser indexedresults[0]unconditionally, crashing the whole batch.This PR keeps one
GeocodingResultper submitted address, in order:location=Noneinstead of crashing or being dropped.To make the results usable:
GeocodingResult.locationis nowOptional[Location].queryfield so each result can map back to the address submitted.matchedproperty (location is not None) as a readability helper.The point of batch geocoding is that N number of inputs corresponds to N number of outputs. If unmatched addresses are silently dropped, like #26 and #27 do, a 100-address batch with 3 failures returns 97 results with no way to tell which 3 failed or where they were.
Keeping them preserves positional alignment and lets callers handle failures explicitly:
Backwards compatibility
Batches with all-matched addresses are unchanged (same count, same order).
Batches containing an unmatched address previously crashed, whereas now the
locationproperty is widened toOptionalas a type-level change only; matched results still carry a realLocationat runtime.