Skip to content

[Fixes #14386] Replace Dataset does not keep in account the user perm…#14387

Open
mattiagiupponi wants to merge 2 commits into
masterfrom
ISSUE_14386
Open

[Fixes #14386] Replace Dataset does not keep in account the user perm…#14387
mattiagiupponi wants to merge 2 commits into
masterfrom
ISSUE_14386

Conversation

@mattiagiupponi

Copy link
Copy Markdown
Contributor

…issions

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot Bot added the cla-signed CLA Bot: community license agreement signed label Jun 26, 2026
@mattiagiupponi mattiagiupponi requested a review from sijandh35 June 26, 2026 16:18

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves the raster and vector upload handlers in GeoNode by adding permission checks for dataset replacement, handling GeoServer deletion failures gracefully, and preventing accidental schema deletion during rollback. The review feedback highlights critical issues, including a potential runtime crash in raster.py due to calling .exists() on a model instance, and a bug in vector.py where incorrect workspace matching during rollback could lead to data loss. Additionally, the reviewer noted that the permission checks are fragile due to substring matching on _to_compact_perms and identified several type hint mismatches.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread geonode/upload/handlers/common/raster.py
Comment thread geonode/upload/handlers/common/vector.py
Comment thread geonode/upload/handlers/common/raster.py
Comment thread geonode/upload/handlers/common/raster.py
Comment thread geonode/upload/handlers/common/vector.py
Comment thread geonode/upload/handlers/common/vector.py
Comment thread geonode/upload/handlers/common/vector.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 5.0.x backport 5.1.x cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace Dataset does not keep in account the user permissions

2 participants