[Fixes #14374] Add deletion of temporary files in case of rollback#14375
Conversation
There was a problem hiding this comment.
Code Review
This pull request extracts the temporary file removal logic into a static method __remove_temporary_file and integrates it into both the final execution step and the rollback process. The review feedback suggests adding a defensive check to prevent an AttributeError if _exec is None, and wrapping the rollback cleanup call in a try-except block to ensure that other rollback steps can proceed even if the cleanup fails.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.