Skip to content

[Fixes #14374] Add deletion of temporary files in case of rollback#14375

Merged
mattiagiupponi merged 2 commits into
masterfrom
ISSUE_14374
Jun 22, 2026
Merged

[Fixes #14374] Add deletion of temporary files in case of rollback#14375
mattiagiupponi merged 2 commits into
masterfrom
ISSUE_14374

Conversation

@mattiagiupponi

Copy link
Copy Markdown
Contributor

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@mattiagiupponi mattiagiupponi requested a review from etj June 22, 2026 13:57
@cla-bot cla-bot Bot added the cla-signed CLA Bot: community license agreement signed label Jun 22, 2026
@mattiagiupponi mattiagiupponi linked an issue Jun 22, 2026 that may be closed by this pull request

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request extracts the temporary file removal logic into a static method __remove_temporary_file and integrates it into both the final execution step and the rollback process. The review feedback suggests adding a defensive check to prevent an AttributeError if _exec is None, and wrapping the rollback cleanup call in a try-except block to ensure that other rollback steps can proceed even if the cleanup fails.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread geonode/upload/handlers/common/vector.py
Comment thread geonode/upload/handlers/common/vector.py Outdated
@mattiagiupponi mattiagiupponi merged commit 7dc7f6b into master Jun 22, 2026
23 of 24 checks passed
@mattiagiupponi mattiagiupponi deleted the ISSUE_14374 branch June 22, 2026 15:22
mattiagiupponi added a commit that referenced this pull request Jun 22, 2026
…14375) (#14376)

* [Fixes #14374] Add deletion of temporary files in case of rollback

* [Fixes #14374] Fix PR suggestions

(cherry picked from commit 7dc7f6b)

Co-authored-by: mattiagiupponi <51856725+mattiagiupponi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 5.1.x cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Zip file content not removed when error happens

2 participants