Skip to content

[Fixes #14369] Map thumbnail is not saved if remote WMS without servi…#14372

Merged
giohappy merged 3 commits into
masterfrom
ISSUE_14369
Jun 22, 2026
Merged

[Fixes #14369] Map thumbnail is not saved if remote WMS without servi…#14372
giohappy merged 3 commits into
masterfrom
ISSUE_14369

Conversation

@mattiagiupponi

Copy link
Copy Markdown
Contributor

…ce are uploaded

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@mattiagiupponi mattiagiupponi requested a review from etj June 22, 2026 13:10
@cla-bot cla-bot Bot added the cla-signed CLA Bot: community license agreement signed label Jun 22, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the thumbnail generation logic in geonode/thumbs/thumbnails.py to use dataset.ows_url as a fallback when dataset.remote_service is not available. The reviewer correctly identified a potential AttributeError on an earlier line (line 340) where dataset.remote_service.service_url is accessed without a null check, and suggested refactoring the block to safely resolve the service URL first.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread geonode/thumbs/thumbnails.py Outdated
@etj etj linked an issue Jun 22, 2026 that may be closed by this pull request
Comment thread geonode/thumbs/thumbnails.py Outdated
@mattiagiupponi mattiagiupponi requested a review from giohappy June 22, 2026 15:35
@giohappy

Copy link
Copy Markdown
Contributor

I don't like much the pre-existing dataset_ows_url property. A private model field with an ows_url getter/setter is better, but I'm fine to keep it for the moment.

@giohappy giohappy merged commit 36ce3dc into master Jun 22, 2026
15 checks passed
@giohappy giohappy deleted the ISSUE_14369 branch June 22, 2026 16:32
@github-actions

Copy link
Copy Markdown
Contributor

The backport to 5.1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-5.1.x 5.1.x
# Navigate to the new working tree
cd .worktrees/backport-5.1.x
# Create a new branch
git switch --create backport-14372-to-5.1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 36ce3dc5bc5f2d82736ba6c024e977782c85771d
# Push it to GitHub
git push --set-upstream origin backport-14372-to-5.1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-5.1.x

Then, create a pull request where the base branch is 5.1.x and the compare/head branch is backport-14372-to-5.1.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 5.1.x cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Map thumbnail is not saved if remote WMS without service are uploaded

3 participants