[Fixes #14369] Map thumbnail is not saved if remote WMS without servi…#14372
Conversation
…ce are uploaded
There was a problem hiding this comment.
Code Review
This pull request updates the thumbnail generation logic in geonode/thumbs/thumbnails.py to use dataset.ows_url as a fallback when dataset.remote_service is not available. The reviewer correctly identified a potential AttributeError on an earlier line (line 340) where dataset.remote_service.service_url is accessed without a null check, and suggested refactoring the block to safely resolve the service URL first.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
I don't like much the pre-existing |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-5.1.x 5.1.x
# Navigate to the new working tree
cd .worktrees/backport-5.1.x
# Create a new branch
git switch --create backport-14372-to-5.1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 36ce3dc5bc5f2d82736ba6c024e977782c85771d
# Push it to GitHub
git push --set-upstream origin backport-14372-to-5.1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-5.1.xThen, create a pull request where the |
…ce are uploaded
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.