Skip to content

fix: handle image URI which combine both tag and digest#383

Open
wilsonjord wants to merge 1 commit into
mainfrom
fix-incorrect-deployment-info
Open

fix: handle image URI which combine both tag and digest#383
wilsonjord wants to merge 1 commit into
mainfrom
fix-incorrect-deployment-info

Conversation

@wilsonjord

Copy link
Copy Markdown
Contributor

Allows correct extraction of tag-only for full image URI which contain both tag and digest. Previous behaviour result in a tag like git123456@sha.

@wilsonjord wilsonjord requested a review from a team as a code owner June 17, 2026 02:39
@wilsonjord wilsonjord requested a review from junghao June 17, 2026 02:40
junghao
junghao previously approved these changes Jun 17, 2026

@junghao junghao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Allows correct extraction of tag-only for full image URI which contain
both tag and digest. Previous behaviour result in a tag like
`git123456@sha`.
@wilsonjord wilsonjord force-pushed the fix-incorrect-deployment-info branch from 4971629 to cc4d689 Compare June 17, 2026 04:34
@wilsonjord wilsonjord requested a review from jajera June 17, 2026 04:35

@jajera jajera left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. only used by nema-mar portal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants