Figure.solar: Fix the baseline image for test_solar_terminators#4675
Merged
Conversation
seisman
added
maintenance
seisman
commented
Jun 12, 2026
| # TODO(GMT>6.6.0): Remove the xfail marker. | ||
| @pytest.mark.xfail( | ||
| condition=Version(__gmt_version__) <= Version("6.6.0"), | ||
| reason="Upstream bug fixed in https://github.com/GenericMappingTools/gmt/pull/8938", |
Member
Author
There was a problem hiding this comment.
Actually I'm not sure if this bug was fixed by GenericMappingTools/gmt#8938
Contributor
Summary of changed imagesThis is an auto-generated report of images that have changed on the DVC remote
Image diff(s)DetailsAdded imagesModified images
Report last updated at commit 5792ba1 |
weiji14
approved these changes
Jun 12, 2026
seisman
removed
needs review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_solar_terminatorsis failing in the GMT Dev Tests workflow. It turns out the current baseline image is correct.This PR updates the baseline image and marks the test as xfail for GMT<=6.6.0. This PR also simplifies the test a little bit.
The correctness of the new baseline image can be confirmed by comparing with
https://www.timeanddate.com/worldclock/sunearth.html?day=17&month=2&year=1990&hour=4&min=25&sec=00&n=%3A&ntxt=&earth=0