Figure.plot: Rename "fill_between" to "between_fill" (alias for -M)

[yvonnefroehlich]

Description of proposed changes

Rename fill_between to beween_fill for -M to be consistent with the other *_fill parameters.
Extends: #3169

Guidelines

• General Guidelines for Pull Request
• Guidelines for Contributing Documentation
• Guidelines for Contributing Code

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash command is:

• /format: automatically format and lint the code

[yvonnefroehlich]

In PR #3169, fill_between was added as an alias for -M of Figure.plot. This is consistent with the method used by matplotlib (https://matplotlib.org/stable/api/_as_gen/matplotlib.pyplot.fill_between.html). However, to be consistent with other parameter names, it should be between_fill, e.g., positive_fill and negative_fill of Figure.wiggle. See also #3169 (comment). @GenericMappingTools/pygmt-maintainers What do people prefer:

• 🎉 Keep fill_between
• 🚀 Change to between_fill

[seisman]

One thing to note is that in parameters such as positive_fill and negative_fill, fill is a noun, whereas in fill_between, it is more like a verb.

[yvonnefroehlich]

Ping @weiji14 and @michaelgrund for your vote here.

[yvonnefroehlich]

I think we should decide this before making the release of v0.19.0.

[seisman]

Or cwe can remove the fill_between alias which was added in #3169, and then work on Figure.fill_between in v0.19.0 or next release.

[yvonnefroehlich]

Or cwe can remove the fill_between alias which was added in #3169, and then work on Figure.fill_between in v0.19.0 or next release.

This would mean we also need to remove the gallery example added in PR #3168 temporarily and add it back after implementing this high-level method.