feat(lobby): add mesh check retries and improve QuickMatch setup - #48
Open
tintinhamans wants to merge 4 commits into
Open
feat(lobby): add mesh check retries and improve QuickMatch setup#48tintinhamans wants to merge 4 commits into
tintinhamans wants to merge 4 commits into
Conversation
Retry incomplete full-mesh checks with correlated attempts and gate QuickMatch startup on a successful mesh result. Preserve legacy client compatibility and requeue players when automatic setup fails.
Serialize registration, cancellation, assignment, and requeue operations. Make lobby removal and bucket cleanup safe under concurrent disconnect and teardown paths.
tintinhamans
marked this pull request as ready for review
August 21, 2026 08:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add one retry for failed mesh checks in custom lobbies and use the same mesh check before starting QuickMatch.
Each check keeps the existing five-second timeout. If the first check fails, the server restarts signalling for the missing peer connections, waits three seconds for them to reconnect, and runs one final check.
QuickMatch runs the mesh check during its existing countdown. The game starts when the mesh succeeds; otherwise, the temporary lobby is removed and the players are requeued.
Legacy clients can still complete mesh checks, but they do not understand the new setup-progress or requeue messages. They may still show the existing 10-second warning while the server is working and recover through the normal teardown and next-lobby flow.
Together with GameClient PR #570, this prevents QuickMatch from starting with an incomplete peer mesh while allowing transient signalling failures to recover without forcing players to restart matchmaking.