fix(ngmp): correct stats and media upload caching - #568
Open
tintinhamans wants to merge 1 commit into
Open
Conversation
|
tintinhamans
marked this pull request as ready for review
August 20, 2026 22:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Player stats:
After a match, the client did not refresh its cached stats. The next match started from the same old values and submitted them as the new totals.
For example:
This could also lose rank progress. A player could earn the 5 points needed for Corporal, but a later update could still be based on the old 4-point Private stats.
The client now refreshes the cache after a successful update. It also ignores old request results when a newer request has already updated the cache.
Screenshots and replays:
Match-end media and upload URLs did not record which match they belonged to.
For example:
The same issue applied to replays:
The client now stores a match ID alongside both the media data and its upload URL. The client uploads them only when both IDs match.
Other changes: