fix: Guard BodyModule access in StealthUpdate::allowedToStealth - #566
Open
seer-by-sentry[bot] wants to merge 1 commit into
Open
fix: Guard BodyModule access in StealthUpdate::allowedToStealth#566seer-by-sentry[bot] wants to merge 1 commit into
seer-by-sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue CLIENT-4ZV, which was an EXCEPTION_ACCESS_VIOLATION_READ at 0x0 in
StealthUpdate::allowedToStealth.The root cause was identified as a NULL pointer dereference when
self->getBodyModule()returned NULL for objects lacking a BodyModule, andgetLastDamageTimestamp()was called on the resulting NULL pointer. Additionally, a potential secondary NULL dereference was identified ifgetBodyModule()->getLastDamageInfo()returned NULL (which it does for baseBodyModuleimplementations).The fix involves:
self->getBodyModule()into a local pointer (body).bodybefore attempting to callbody->getLastDamageTimestamp()in theSTEALTH_NOT_WHILE_TAKING_DAMAGEcondition.body->getLastDamageInfo()before dereferencing it, to prevent crashes for objects with non-ActiveBody modules.These changes ensure that
getLastDamageTimestamp()andgetLastDamageInfo()are only called on validBodyModuleInterfacepointers.Fixes CLIENT-4ZV
This PR was automatically generated by Sentry. You can adjust this setting at any time.