Skip to content

deps: fix 5 security alerts, incl. a sharp override blocking the patch - #140

Merged
GeiserX merged 1 commit into
mainfrom
deps/nodemailer-sharp-sep2026
Sep 11, 2026
Merged

GeiserX merged 1 commit into
mainfrom
deps/nodemailer-sharp-sep2026

Conversation

@GeiserX

@GeiserX GeiserX commented Sep 11, 2026

Copy link
Copy Markdown
Owner

Five open Dependabot alerts on main, all resolved by two version bumps.

The sharp one is worth calling out: next already requires sharp: ^0.35.4, but our own root overrides entry pinned it to ^0.35.0, so the tree sat on the vulnerable 0.35.3. The override was the only thing holding it back.

Alert Severity Package Was Now
#176 HIGH sharp 0.35.3 0.35.4
#174 HIGH nodemailer 9.0.1 9.1.1
#175 MODERATE nodemailer 9.0.1 9.1.1
#173 MODERATE nodemailer 9.0.1 9.1.1
#172 MODERATE nodemailer 9.0.1 9.1.1

Alert #175 needs > 9.1.0, so 9.1.1 is the floor that clears all four nodemailer advisories at once.

Changes

package.json:

  • nodemailer dependency ^9.0.1 to ^9.1.1
  • nodemailer override ^9.0.1 to $nodemailer, so the range and the override cannot drift apart again
  • sharp override ^0.35.0 to ^0.35.4

package-lock.json: nodemailer 9.1.1, sharp 0.35.4 and its 17 platform binaries, libvips 1.3.3. No packages added or removed.

Verification

  • vitest run: 1078 passed (49 files)
  • tsc --noEmit: clean
  • No remaining copy of either package below the patched version anywhere in the lockfile

npm run lint fails on this branch, but it fails the same way on pristine main (TypeError: Converting circular structure to JSON inside ESLint's own config loader, 'react' closes the circle). Verified by reverting both files to main, reinstalling and re-running. Unrelated to this change and left alone.

Summary by CodeRabbit

  • Chores
    • Updated email delivery and image processing components to newer versions.
    • Aligned the email delivery override with the declared dependency version.

nodemailer was locked at 9.0.1, which carries four advisories. Bumped the
floor to ^9.1.1 (the patched version for all four) and switched the
override to the $nodemailer reference so the dependency range and the
override can no longer drift apart.

sharp was stuck at 0.35.3 because our own root override pinned it to
^0.35.0. next already requires ^0.35.4, so the override was the only
thing holding the tree on the vulnerable version. Raised it to ^0.35.4.

Alerts closed: #172, #173, #174, #175 (nodemailer), #176 (sharp).
@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: a195eba0-4a2b-47ae-b472-fe7fa94c94a2

📥 Commits

Reviewing files that changed from the base of the PR and between 2ac352c and f6c2ed1.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json, !**/package-lock.json
📒 Files selected for processing (1)
  • package.json

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The pull request updates nodemailer to ^9.1.1, aligns its override with the dependency, and updates the sharp override to ^0.35.4.

Changes

Dependency version alignment

Layer / File(s) Summary
Dependency version alignment
package.json
The nodemailer dependency changes to ^9.1.1. Its override now references $nodemailer. The sharp override changes to ^0.35.4.

Priority: ⬆️ High

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to f6c2e

The dependency updates are aligned and verified, with no remaining merge-blocking concern.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description gives a detailed summary, change list, security context, and verification results. It does not follow the repository template because it omits the required Type of Change, Database Cha… Update the description to include every template section. Mark non-applicable items explicitly, select the applicable change and database options, record the test results, complete the security checklist, and state deployment considerations…
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the dependency security fixes and the sharp override issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description gives a detailed summary, change list, security context, and verification results. It does not follow the repository template because it omits the required Type of Change, Database Changes, Security Checklist, Deployment Notes, and Screenshots sections.

Resolution

Update the description to include every template section. Mark non-applicable items explicitly, select the applicable change and database options, record the test results, complete the security checklist, and state deployment considerations or that none exist.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch deps/nodemailer-sharp-sep2026

Warning

Some tools did not complete. Review the errors below.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

package.json

ESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@GeiserX
GeiserX merged commit 41ee271 into main Sep 11, 2026
13 checks passed
@GeiserX
GeiserX deleted the deps/nodemailer-sharp-sep2026 branch September 11, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant