Skip to content

Feat/sonarqube#163

Merged
EdenBernhard merged 88 commits into
mainfrom
feat/sonarqube
May 26, 2026
Merged

Feat/sonarqube#163
EdenBernhard merged 88 commits into
mainfrom
feat/sonarqube

Conversation

@EdenBernhard

Copy link
Copy Markdown
Collaborator

No description provided.

PrussianBaron and others added 30 commits May 4, 2026 15:11
… geschrieben. Die dazugehörigen Abhängigkeiten in requirements.txt angepasst. Sie werden in test_main.py aufgerufen.

Namens faktorisierung ist schwer bei den Klassennamen da bei tests der pycharm Debugger eher auf klassen mit test_ vorne guckt. Deswegen leider test_
* Rename models.py to Models.py

* Rename auth.py to Auth.py

* Rename Routes.py to routes.py

* Added Refactoring Summary

* Refactor documentation for code naming conventions

* Fix spelling errors in refactoring documentation

Corrected spelling of 'Refaktorisierung' and 'Frontend'.

* Delete project/data/LazyCookDB.sqlite3

* AI Agent md's changed

* Passwort und Email Änderung zu Popups geändert. und neugeordnet untereinander

* Update README.md to mark tasks as completed for account management features

* Add CI/CD pipeline and Super Linter configuration

* Test für lint

* Test ci/cd lint.yml

* Test ci/cd lint.yml

* Test ci/cd lint.yml

* Test ci/cd lint.yml regex Filter

* Test ci/cd lint.yml

* Test ci/cd lint.yml

* Test ci/cd lint.yml regex Filter angepasst

* Tests für Database, passwort überprüfung und email überürufung wurden geschrieben. Die dazugehörigen Abhängigkeiten in requirements.txt angepasst. Sie werden in test_main.py aufgerufen.
Namens faktorisierung ist schwer bei den Klassennamen da bei tests der pycharm Debugger eher auf klassen mit test_ vorne guckt. Deswegen leider test_

* ci pipeline abhägigkeit mit rein gemacht

* Feat bei Ci yml entfernt

* Update FILTER_REGEX_INCLUDE pattern in lint.yml

* Update lint.yml

* Enable validation for the entire codebase

* Update lint.yml

* Update lint.yml

* Enable validation for all codebase in lint workflow

* Remove Python Black and Markdown validation

* Update lint workflow to include additional validations

* Update FILTER_REGEX_INCLUDE to support YAML files

* Update lint.yml

* Update lint.yml

* Refactor CI configuration to use Docker Compose v2 syntax and add GitHub Super Linter step

* Test ci.yml

* Update ci.yml

* Enable Flake8 validation for Python files

* Test ci.yml

* Remove 'feat/*' branch from push trigger in CI configuration

* Python black gelöst

---------

Co-authored-by: Samuel Goebel <goebelsamuel@gmail.com>
Co-authored-by: Eden Tabea Bernhard <105359952+EdenBernhard@users.noreply.github.com>
Co-authored-by: Nicoolaus <162422307+Nicoolaus@users.noreply.github.com>
Co-authored-by: Hellocrafting <alexanderfgroer@gmail.com>
Co-authored-by: nicla <niclas.matzke@gmail.com>
Co-authored-by: Hellocrafting <75727565+Hellocrafting@users.noreply.github.com>
# Conflicts:
#	project/data/LazyCookDB.sqlite3
# Conflicts:
#	.github/workflows/ci.yml
#	project/backend/tests/test_database.py
#	project/backend/tests/test_email.py
#	project/backend/tests/test_main.py
#	project/backend/tests/test_password.py
* Separate linter configuration into its own workflow file

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Update README.md to reflect linter workflow separation and installation instructions

---------

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
# Conflicts:
#	project/backend/Database.py
#	project/backend/EmailService.py
#	project/backend/Routes.py
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* Feature: Forgot Password link in signin modal. Popup for Email Input. Konto deletion reactivation.

* Feature: Email and Password change popup width changed

* Feature: Fix problem with refresh token and include show Password

* Feature: forgot password functionality works with redirection to homepage

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Fix: Copilot review suggestion

* fix: make password visibility toggle keyboard focusable

Agent-Logs-Url: https://github.com/GalacticCodeGambit/LazyCook/sessions/bf26f4ce-caa3-43fa-b940-13d7be23d7bf

Co-authored-by: EdenBernhard <105359952+EdenBernhard@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 21, 2026 08:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.

Comment thread project/sonar-project.properties Outdated
Comment thread project/sonar-project.properties Outdated
Comment thread project/backend/requirements.txt
Comment thread .github/workflows/sonarqube.yml
Comment thread .github/workflows/sonarqube.yml
Comment thread .github/workflows/sonarqube.yml
Comment thread .github/workflows/sonarqube.yml Outdated
Comment thread .github/workflows/sonarqube.yml
Copilot AI review requested due to automatic review settings May 21, 2026 08:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 14 comments.

Comment thread project/sonar-project.properties Outdated
Comment thread project/sonar-project.properties
Comment thread project/sonar-project.properties Outdated
# Quellen + Tests
sonar.sources=backend,frontend/app
sonar.tests=backend/tests
sonar.exclusions=**/node_modules/**,**/__pycache__/**,**/.next/**,frontend/app/components/ui/**,**/*.config.*,**/coverage/**,backend/tests/**
Comment thread .github/workflows/sonarqube.yml
Comment thread .github/workflows/sonarqube.yml
Comment thread .github/workflows/sonarqube-main.yml
Comment thread .github/workflows/sonarqube-main.yml Outdated
Comment thread .github/workflows/sonarqube-main.yml Outdated
Comment thread .github/workflows/sonarqube.yml
Comment thread .github/workflows/sonarqube-main.yml Outdated
Copilot AI review requested due to automatic review settings May 21, 2026 09:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 11 comments.

Comment thread project/sonar-project.properties Outdated
Comment thread project/sonar-project.properties Outdated
Comment thread .github/workflows/sonarqube.yml
Comment thread .github/workflows/sonarqube.yml
Comment thread .github/workflows/sonarqube.yml Outdated
Comment thread .github/workflows/sonarqube-main.yml
Comment thread .github/workflows/sonarqube-main.yml
Comment thread .github/workflows/sonarqube-main.yml
Comment thread .github/workflows/sonarqube-main.yml Outdated
Comment thread .github/workflows/sonarqube-main.yml
Copilot AI review requested due to automatic review settings May 21, 2026 09:13
@sonarqubecloud

Copy link
Copy Markdown

❌ The last analysis has failed.

See analysis details on SonarQube Cloud

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 8 comments.

Comment thread project/sonar-project.properties Outdated
sonar.sourceEncoding=UTF-8

# Python
sonar.python.version=3.10
Comment on lines +1 to +74
name: SonarCloud Analysis

on:
pull_request:
branches: [main, master]
workflow_dispatch:

permissions:
contents: read

jobs:
sonarcloud:
name: Build, Test & Sonar Scan
runs-on: ubuntu-latest

steps:
- name: Checkout repository
uses: actions/checkout@v4
with:
fetch-depth: 0

# =====================================================
# BACKEND (Python / FastAPI) – Tests + Coverage
# =====================================================
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: "3.10"

- name: Install backend dependencies
working-directory: project/backend
run: |
python -m pip install --upgrade pip
python -m pip install -r requirements.txt
python -m pip install "pytest-cov>=5,<7" "coverage>=7"

- name: Run backend tests with coverage
working-directory: project
run: |
python -m pytest \
--cov=backend \
--cov-report=xml:backend/coverage.xml \
--cov-report=term-missing \
backend/tests/
continue-on-error: true

# =====================================================
# SONARCLOUD SCAN
# =====================================================
- name: SonarQube Scan
uses: SonarSource/sonarqube-scan-action@v3
with:
projectBaseDir: project
args: >
-Dsonar.projectKey=GalacticCodeGambit_LazyCook
-Dsonar.organization=galacticcodegambit
-Dproject.settings=sonar-project.properties
-Dsonar.python.coverage.reportPaths=backend/coverage.xml
-Dsonar.python.version=3.10
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}

- name: SonarCloud Quality Gate check
id: sonar-qg
uses: SonarSource/sonarqube-quality-gate-action@master
timeout-minutes: 5
continue-on-error: true
with:
scanMetadataReportFile: project/.scannerwork/report-task.txt
env:
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}

# =====================================================
Comment on lines +25 to +29
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: "3.10"

Comment thread .github/workflows/sonarqube.yml Outdated

- name: SonarCloud Quality Gate check
id: sonar-qg
uses: SonarSource/sonarqube-quality-gate-action@master
Comment on lines +163 to +167
# Sucht in den Components die mit path enden ODER deren path == argument
v=$(echo "${tree_resp}" | jq -r --arg p "$path" --arg k "$metric" \
'[.components[]? | select(.path == $p)]
| .[0].measures[]? | select(.metric==$k) | .value' 2>/dev/null)
if [ -n "$v" ] && [ "$v" != "null" ] && [ "$v" != "-" ]; then
Comment thread .github/workflows/sonarqube-main.yml Outdated
Comment on lines +4 to +7
pull_request:
branches: [main, master]
workflow_dispatch:

Comment on lines +25 to +29
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: "3.10"

Comment thread .github/workflows/sonarqube-main.yml Outdated

- name: Wait for analysis
id: qg
uses: SonarSource/sonarqube-quality-gate-action@master
Copilot AI review requested due to automatic review settings May 26, 2026 10:39
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
5.9% Coverage on New Code (required ≥ 80%)
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 16 comments.

Comment thread project/backend/Database.py Outdated
Comment thread project/backend/Database.py
Comment thread project/backend/Recipe.py
Comment thread project/frontend/lib/auth.tsx
Comment thread project/frontend/lib/auth.tsx Outdated
Comment thread .github/workflows/sonarqube-main.yml Outdated
Comment thread .github/workflows/sonarqube-main.yml Outdated
Comment thread .github/workflows/sonarqube-main.yml
Comment thread .github/workflows/sonarqube.yml Outdated
Comment thread .github/workflows/sonarqube-main.yml Outdated
@EdenBernhard EdenBernhard requested a review from Copilot May 26, 2026 11:14
@EdenBernhard EdenBernhard self-assigned this May 26, 2026
@EdenBernhard EdenBernhard merged commit c548f6f into main May 26, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 6 comments.

Comment thread .github/workflows/sonarqube.yml
Comment thread project/backend/Database.py
Comment thread project/frontend/lib/auth.tsx
Comment thread project/backend/Recipe.py
Comment thread .github/workflows/sonarqube.yml
Comment thread project/frontend/app/profile/changePasswordPopup.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants