Some Linux build fixes#29
Open
CreativeCylon wants to merge 3 commits into
Open
Conversation
`RmtMutexCreate()` uses `new` in the non WIN32 path. Add the missing include and fix the build error.
Normally `libicudata.so` should be pulled in transitively so no need to `patchelf`, but if this was not done, only then `patchelf`. This also avoid an issue when executing the binary since normally the patchelf case would be avoided, also avoiding the hard-coded libicudata.so.70 . Some systems might have a different/newer version of the library pulled in transitively, but previously that was being `patchelf`ed away with the hard-corded version.
Deprecated since Qt 6.9 so with `-Wall` this is a build error. For Qt 6.7 and above `checkStateChanged()` should be used.
CreativeCylon
commented
May 29, 2026
| if (LINUX) | ||
| if (ICU_DATA_NEEDS_PATCHING) | ||
| message(WARNING "Qt6Core does not link libicudata. Manually adding libicudata.so.70.") | ||
| add_custom_command(TARGET ${target} POST_BUILD COMMAND patchelf --add-needed libicudata.so.70 $<TARGET_FILE:${target}>) |
Contributor
Author
There was a problem hiding this comment.
Maybe we can get rid of the patchelf fully. Not sure why this was needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Came across these while building with my system's Qt.