Skip to content

fix: make the deployment scripts start every node and stop releasing what cannot run - #548

Merged
eigmax merged 1 commit into
devfrom
audit/72-deploy-release
Nov 16, 2026
Merged

eigmax merged 1 commit into
devfrom
audit/72-deploy-release

Conversation

@KSlashh

@KSlashh KSlashh commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Audit items L72, L74, L75, L76, L77. Depends on #537. Review against audit/39-40-release-tooling; merge the parent first, then retarget this PR to dev.

Bootnodes (L72). Only the Docker entrypoint turned BOOTNODES into --bootnodes; a node started any other way ignored it. --bootnodes now also reads BOOTNODES, comma-separated, and an empty value means none, as in .env.template. The deployment run.sh scripts passed --bootnodes $bootnode_urls, a variable nothing sets, which left the flag without a value. They now load their .env.<role> template, where BOOTNODES is set, and drop the flag.

start_nodes.sh (L76). Both the regtest and testnet4 scripts ran .run.sh for the operator, which does not exist. On testnet4, committee_0 and operator_0 shared RPC port 8902 and P2P port 8445; committee_0 now uses RPC 8900 and operator_0 P2P 8446, as on regtest. committee_0 keeps P2P 8445, which the bootnode addresses use.

Challenger docs (L74). There is no Challenger actor; the challenge and run-challenger-node commands now name the Verifier role and its verifier_0/.env.verifier_0 template, which replaces the missing challenge_0 directory.

challenge binary (L75). challenge needs the rpc-debug-endpoints feature and calls an endpoint only such a node serves. Release builds leave the feature out, so the collect step skipped the binary without a word. It is no longer listed, a listed binary that is missing now fails the release, and the challenge command explains how to build both from source.

Regtest proof builder image (L77). The image is built with regtest consensus constants but was tagged latest and with the version. It is now tagged regtest and regtest-<version tag>.

Tests: BOOTNODES gives each comma-separated bootnode, the flag takes precedence, and an empty value gives none. Clippy with -D warnings and fmt pass; the scripts pass bash -n and the workflows parse.

The test coverage and validation notes above are from the zkm PR notes. Branch scope and diff formatting were checked locally; builds and tests were not rerun during publication.

@eigmax
eigmax changed the base branch from audit/39-40-release-tooling to dev November 16, 2026 07:09
@eigmax
eigmax force-pushed the audit/72-deploy-release branch from bc378fd to defbae5 Compare November 16, 2026 07:12
@eigmax
eigmax merged commit 219571f into dev Nov 16, 2026
4 checks passed
@eigmax
eigmax deleted the audit/72-deploy-release branch November 16, 2026 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants