Repository navigation
fix: make the deployment scripts start every node and stop releasing what cannot run - #548
Merged
Merged
Conversation
blake-pro
approved these changes
Nov 16, 2026
eigmax
force-pushed
the
audit/72-deploy-release
branch
from
November 16, 2026 07:12
bc378fd to
defbae5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit items L72, L74, L75, L76, L77. Depends on #537. Review against
audit/39-40-release-tooling; merge the parent first, then retarget this PR todev.Bootnodes (L72). Only the Docker entrypoint turned
BOOTNODESinto--bootnodes; a node started any other way ignored it.--bootnodesnow also readsBOOTNODES, comma-separated, and an empty value means none, as in.env.template. The deploymentrun.shscripts passed--bootnodes $bootnode_urls, a variable nothing sets, which left the flag without a value. They now load their.env.<role>template, whereBOOTNODESis set, and drop the flag.start_nodes.sh (L76). Both the regtest and testnet4 scripts ran
.run.shfor the operator, which does not exist. On testnet4, committee_0 and operator_0 shared RPC port 8902 and P2P port 8445; committee_0 now uses RPC 8900 and operator_0 P2P 8446, as on regtest. committee_0 keeps P2P 8445, which the bootnode addresses use.Challenger docs (L74). There is no
Challengeractor; thechallengeandrun-challenger-nodecommands now name theVerifierrole and itsverifier_0/.env.verifier_0template, which replaces the missingchallenge_0directory.challenge binary (L75).
challengeneeds therpc-debug-endpointsfeature and calls an endpoint only such a node serves. Release builds leave the feature out, so the collect step skipped the binary without a word. It is no longer listed, a listed binary that is missing now fails the release, and thechallengecommand explains how to build both from source.Regtest proof builder image (L77). The image is built with regtest consensus constants but was tagged
latestand with the version. It is now taggedregtestandregtest-<version tag>.Tests:
BOOTNODESgives each comma-separated bootnode, the flag takes precedence, and an empty value gives none. Clippy with-D warningsand fmt pass; the scripts passbash -nand the workflows parse.The test coverage and validation notes above are from the zkm PR notes. Branch scope and diff formatting were checked locally; builds and tests were not rerun during publication.