Skip to content

Detail: Accessibility rows and episode meta keep one gap; Watchlist read-out uses the overlay's bands - #903

Merged
GLinnik21 merged 2 commits into
mainfrom
crx-vs-q236
Oct 21, 2026
Merged

GLinnik21 merged 2 commits into
mainfrom
crx-vs-q236

Conversation

@GLinnik21

Copy link
Copy Markdown
Owner

Three spacing follow-ups to the vertical stack (#901), each approved by the owner after seeing before/after captures.

What changes on screen

  • Detail › About › Accessibility: the badge rows sit 68 px under the heading, like Information and Languages, instead of 64. They move down 4 px.
  • Detail › episodes, an episode with no summary but an air date: the date and rating row is one gap under the title, not two. It moves up 24 px.
  • Detail › episodes, a title-only platter: no trailing gap.
  • An episode with a rating chip but no air date keeps that row, because the row is present whenever it paints a date or a chip. The platter therefore still reaches the chip.
  • Watchlist empty read-out: nothing visible changes. It now places its bands through StatusOverlay::failed_page_text_bands, the overlay's own layout, instead of keeping a copy. The reason text stays where it was. Only the reserved reason box height changes, from 2×line to line pitch + line. It is the same for a one-line and a two-line reason.

Evidence

  • Painted-position tests, each seen failing on main first:
    • Accessibility: the first description was at 542.4, want 546.4.
    • Episodes date row: 128, want 1 MD under the title.
    • Title-only platter: trailing MD 128.
    • Rating chip without a date: chip run past the platter bottom, 370.
    • Watchlist read-out box: 67.2 vs 70.56.
  • Gates on the committed tree:
    • make check ok, largest test result: ok. 1846 passed; 0 failed; 64 ignored.
    • make test-hostsim ok.
    • make check-nodef ok.
    • make check-replay: 6 replays, all verdict=SAME, no fixture re-recorded.
  • Sim + mock captures, base against head:
    • About: only the Accessibility column differs.
    • Episodes: only the no-summary episode's date row differs. The rating-only episode's chip is unchanged.

🤖 Generated with Claude Code

GLinnik21 and others added 2 commits October 21, 2026 22:01
Q2: the Watchlist read-out places its verdict and reason through StatusOverlay's own bands
(StatusOverlay::failed_page_text_bands); the reason box is the reserved two-line slot, invisible
(top-anchored text). Q3: Detail About's Accessibility heading-to-first-row 64 -> 68, rows move down
4 px like Information/Languages. Q6: an empty episode summary is absent from the meta stack, so
the date stands one MD under the title and a title-only platter has no trailing MD.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
One row paints the date and the rating chip, so it is absent only with neither; the platter
reaches the chip. Q6 (b) gets its own test.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@GLinnik21
GLinnik21 merged commit acf1d2a into main Oct 21, 2026
19 checks passed
@GLinnik21
GLinnik21 deleted the crx-vs-q236 branch October 21, 2026 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant