Repository navigation
Force Direct Play: the audio refusal names the codec - #898
Merged
Merged
Conversation
ForcedFailure::Audio and AudioNeedsConversion carry the refused track's codec (friendly_codec, name only), the read-out says "DTS audio can't play without conversion" instead of "this audio format", and the event log line playback_policy names the raw codec. Empty codec keeps the generic sentence. New keys widgets.verdict.forced_audio_codec and forced_audio_conversion_codec in all 8 locales. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…dly name Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Force Direct Play refuses a file because of its audio, the read-out now names the codec ("…this audio (DTS) can't play without conversion") instead of "this audio format". Field reports like the one in discussion #695 and the C1 refusal on Reddit could not tell us which codec hit the wall.
ForcedFailure::Audio { codec }andAudioNeedsConversion { codec }carryfriendly_codec's name for the track the viewer was going to play (session pick → remembered/selected → language → file default → first track → Media-levelacodec). An unknown codec keeps the old generic sentence.{codec}in all 8 locales:widgets.verdict.forced_audio_codec,widgets.verdict.forced_audio_conversion_codec.playback_policy: Force Direct Play refused audio codec <raw> (<friendly>), so a log tellsdcafromdts. Telemetry payload unchanged (it is consent-previewed).PlayVerdict::text()returnsCow<str>; only the two codec sentences allocate, on the failure screen only.ForcedFailureis no longerCopy.No layout or colour change: the read-out shows the verdict sentence where it already did.
Verification
forced_audio_refusal_names_the_codec(dca→ "DTS",truehd→ "Dolby TrueHD") failed to compile onmain(nocodecfield), then passed; plusforced_audio_refusal_without_a_codec_keeps_the_generic_sentence.make checkon the committed tree: everytest result:ok, 0 failed (largest:1848 passed; 0 failed; 64 ignored).make check-nodefclean.First PR of the DTS/lossless audio plan; the
dcaspelling fix stacks on this one.🤖 Generated with Claude Code