ci: Add testing for the integration of geosPythonPackages in GEOS#141
Merged
Conversation
alexbenedicto
added
the
test-geos-integration
…in GEOS is modified
alexbenedicto
requested review from
RomainBaville,
jafranc and
paloma-martinez
jafranc
reviewed
Oct 13, 2025
jafranc
left a comment
jafranc
left a comment
Collaborator
There was a problem hiding this comment.
It looks good though can you set up 2 dummy PR to your PR that check if the workflow is going as planned ?
| REQUIRES_GEOS_TEST=false | ||
| AFFECTED_PACKAGES="" | ||
|
|
||
| for file in $CHANGED_FILES; do |
Collaborator
There was a problem hiding this comment.
What if some files req integration and some other doesn't ? IIUC now we are in "if any" behavior
Contributor
Author
There was a problem hiding this comment.
Yes the logic right here is if any file of one these folders is modified, test-geos-integration is mandatory
Collaborator
paloma-martinez
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #107 and replaces #121 by not using cross-repository implementation.