Move relperm driver#4040
Open
dkachuma wants to merge 44 commits into
Open
Conversation
dkachuma
added
type: feature
dkachuma
requested review from
OmarDuran,
cssherman,
herve-gross,
jafranc,
jhuang2601 and
rrsettgast
as code owners
herve-gross
approved these changes
May 22, 2026
jhuang2601
approved these changes
May 28, 2026
Updated the link for PR #4040 to the new baseline tar.gz file.
Merged
joshua-white
approved these changes
Jun 11, 2026
joshua-white
left a comment
joshua-white
left a comment
Contributor
There was a problem hiding this comment.
Looks great. Nice tutorial too.
Co-authored-by: Joshua White <jawhite@llnl.gov>
bd713
approved these changes
Jun 11, 2026
jafranc
approved these changes
Jun 12, 2026
jafranc
left a comment
jafranc
left a comment
Contributor
There was a problem hiding this comment.
Great addition/correction 👍
Thanks.
Made a dep PR for extension/correction for 3-phases.
…m/GEOS-DEV/GEOS into dkachuma/refactor/rel-perm-driver
* adding 3 phase ternary plots * typo introduced * Update src/coreComponents/constitutiveDrivers/docs/RelpermDriver.rst --------- Co-authored-by: Dickson Kachuma <81433670+dkachuma@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building on the constitutive testing infrastructure established in PR3883, this pull request moves the
RelpermDriveruse the same framework.ConstitutiveDriverrather than directly fromTaskBase.historicalSaturationshandling for cases with hysteresis.inputFiles/constitutiveDriver/, adds new ATS integration tests for various model types (Table, Brooks-Corey, van Genuchten), and provides full Sphinx documentation alongside a working XML example.testRelPermHysteresisunit test fromintegrationTeststoconstitutive/unitTests