Repository navigation
fix(computer-use): refine virtual cursor appearance - #3433
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the Computer Use virtual cursor smaller, with a dark gray fill, a fixed 3px white outline, and a downward shadow in the macOS/Windows native overlays and Web preview. Scale the contour around its existing hotspot so visual feedback stays aligned with input coordinates. On macOS, correct the shadow direction for the flipped view and cast one shadow from the outlined silhouette.
Type and Areas
Type: UI/UX, bug fix
Areas: desktop Computer Use (macOS/Windows), Web UI preview
Motivation / Impact
The previous cursor was large and light gray, with no contrasting edge; the macOS shadow was offset upward. The smaller outlined cursor remains visible against both light and dark captured content. The preview keeps its outline at 3px when scaling the SVG contour.
Verification
node scripts/test-macos-control-pointer.mjs— passed; native cursor persists, follows its target, respects occlusion, and does not take focus. Inspected the rendered production cursor on light/dark backgrounds and confirmed the shadow falls below it.pnpm --dir src/web-ui run test:run src/app/components/ComputerUseControlCard.test.tsx src/app/components/computer-use src/infrastructure/api/adapters/peer-device-adapter.test.ts— 79 passed.pnpm run check:webandpnpm run theme:color-audit:all— passed.cargo test --locked -p openbitfun-desktop --features devtools --lib computer_use— 163 passed, 9 opt-in native tests ignored.cargo build --locked -p openbitfun-desktop --features devtools— passed after the final native shadow correction.node scripts/test-windows-computer-use-native.mjs --check --target x86_64-pc-windows-msvc— passed. Also executed the production rasterizer's updated pixel test in isolation on macOS.pnpm run fmt:rs,git diff --check, and the introduced Git object-size check — passed.Reviewer Notes
AI-assisted, with focused automated testing and local visual verification. Windows native rendering was cross-compiled but not exercised on a Windows desktop; remote end-to-end behavior was not exercised. No protocol, persisted data, control routing, or cursor animation changes.
Checklist