Repository navigation
fix(flowchat): guard submission placement reentry - #3358
Merged
Merged
Conversation
Prevent synchronous virtualizer measurement callbacks from re-entering submission placement and consuming the pending intent twice. Revalidate session, surface, and intent ownership before applying geometry. Make placement state updates idempotent and clear inactive pending sends. Cover cancellation, replacement, and measurement failure paths with regression tests.
Mock the unified API boundary before transport initialization so pet unit tests cannot leave WebSocket retries running during teardown. Flush React updates on unmount and assert resize requests against the API mock actually used by the component. Keep floating menu changes from triggering window resize requests while preserving layout measurement when the inline composer changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent synchronous virtualizer measurement callbacks from re-entering
submission placement and consuming the pending intent twice.
Revalidate session, surface, and intent ownership before applying geometry.
Make placement state updates idempotent and clear inactive pending sends.
Cover cancellation, replacement, and measurement failure paths with
regression tests.