fix(cli): wrap cursor navigation in selector panels#895
Open
kev1n77 wants to merge 2 commits into
Open
Conversation
Change move_up/move_down in all CLI selector panels to use modulo-based wrapping instead of saturating clamp, so pressing Down on the last item jumps to the first and pressing Up on the first item jumps to the last. Affected panels: agent, command_menu, command_palette, mcp, model, provider, session, skill, subagent, theme.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
move_up/move_downin all CLI selector panels to use modulo-based wrapping instead of saturating clamp, so pressing Down on the last item jumps to the first and pressing Up on the first item jumps to the last.Previously, all selectors used
saturating_sub(1)for up and(idx + 1).min(len - 1)for down, which clamped at boundaries. This matches the wrapping behavior already implemented inquestion.rs.Affected panels