Repository navigation
feat(server): support custom ServerSocketFactory - #55
Open
2748109647 wants to merge 1 commit into
Open
2748109647 wants to merge 1 commit into
2748109647 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ServerSocketFactorytoHTTPListenerConfigurationand use it to create the listener socket.Fixes #52
Verification
mvn -B -ntp '-Dtest=HTTPServerThreadTest' test— 2 passed, 0 failures/errors.git diff --check— passed.mvn -B -ntp clean test— compiled all sources and ran 2,623 tests; 14 failures occurred in existing Windows-sensitive multipart/form-data tests. The unmodifiedmainbranch reproduced the same failure modes: invalid:characters in generated test log paths and local socket resets. The targeted factory tests pass. Linux CI has not yet run.