Fix: enable pinch-to-zoom on precision touchpads#29
Open
andrewtheart wants to merge 1 commit into
Open
Conversation
PointerWheelAction only checked the physical keyboard Ctrl state (Utils.IsKeyPressed) to decide whether a wheel event is a zoom gesture. A precision-touchpad pinch arrives as a Ctrl-modified wheel where the Control flag is on the event's KeyModifiers, not the keyboard state, so pinch gestures were ignored. Also check e.KeyModifiers.HasFlag(VirtualKeyModifiers.Control).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Enables pinch-to-zoom on precision touchpads, which currently does nothing.
Why
PointerActionsManager.PointerWheelActiongates the zoom branch onUtils.IsKeyPressed(VirtualKey.Control). A precision-touchpad pinch is delivered by Windows as a Ctrl-modified mouse-wheel message, but thatControlflag rides on the wheel event (PointerRoutedEventArgs.KeyModifiers) and is not reflected in the physical keyboard state thatUtils.IsKeyPressedreads. So pinching a precision touchpad falls through to the scroll branch and never zooms.Change
Also check
e.KeyModifiers.HasFlag(VirtualKeyModifiers.Control)in the zoom condition. Physical Ctrl+wheel keeps working exactly as before; pinch now zooms too.Testing
TextControlBox.csproj, Release/x64).Contributing this back upstream after hitting it while using TextControlBox as a vendored editor.