Skip to content

Fix: caret can fall off-screen after typing on long lines #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrewtheart wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: caret can fall off-screen after typing on long lines #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions TextControlBox/Core/Text/TextActionManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,8 +500,15 @@ public void AddCharacter(string text, bool ignoreSelection = false, bool ignoreI
}

eventsManager.CallTextChanged();
scrollManager.ScrollLineIntoViewIfOutside(cursorManager.LineNumber, false);

// Keep the caret visible after typing using the same helper every other edit
// operation uses. Backspace, Delete, AddNewLine, Undo and Redo all call
// UpdateScrollToShowCursor; AddCharacter was the only one still using the
// line-granularity ScrollLineIntoViewIfOutside, which does not scroll while the
// caret stays on the same (long) line, so a caret typed past the right edge could
// fall outside the rendered area. Using the shared helper makes the caret follow
// consistent with the rest of the edit operations.
scrollManager.UpdateScrollToShowCursor(false);

canvasUpdateManager.UpdateAll();
}

Expand Down