Fix: "Hide videos from channels" doesn't work for collab videos (local API) - #9697
Open
Shadorc wants to merge 9 commits into
Open
Fix: "Hide videos from channels" doesn't work for collab videos (local API)#9697Shadorc wants to merge 9 commits into
Shadorc wants to merge 9 commits into
Conversation
Shadorc
requested review from
PikachuEXE,
absidue and
radmorecameron
as code owners
August 26, 2026 17:04
FreeTubeBot
enabled auto-merge (squash)
August 26, 2026 17:14
github-actions
Bot
added
the
PR: waiting for review
PikachuEXE
reviewed
Aug 26, 2026
| const lowerCaseAuthor = props.data.author?.toLowerCase() | ||
|
|
||
| if (channelsHidden.value.some(ch => ch.name === props.data.authorId) || channelsHidden.value.some(ch => ch.name === props.data.author) || (forbiddenTitles.value.some((text) => lowerCaseAuthor.includes(text)))) { | ||
| if (channelsHidden.value.some(ch => ch.name === props.data.authorId || (props.data.collaborators?.length > 0 && ch.name === props.data.collaborators[0].id)) || |
Member
There was a problem hiding this comment.
props.data.collaborators[0].id: Does that mean the first guy (XXX and YYY: XXX) or 2nd one (YYY`)
Contributor
Author
There was a problem hiding this comment.
Collaborators array always contains the original author as the first element
It's either (author is not a field, but you get the idea):
{ author: 'XXX', collaborators: [] }
or
{ author: null, collaborators: ['XXX', 'YYY'...] }
PikachuEXE
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
Addresses #7871 (only for local API).
This does not fix the issue for Invidious API as collaborators are not supported yet: iv-org/invidious#5507
Description
Fix "Hide videos from channels" setting not working with videos having collaborators.
Videos with collaborators are now hidden correctly for:
Fix "Hide channel" option not appearing in the dropdown menu for videos with collaborators.
Fix video's author not having clickable URL when they have collaborators (redirect to the main author)
Tested with both Local API and Invidious
Testing
I don't know this channel but KSI does a lot of collaborations, it's easier to test.
All of these tests assume that no channels are hidden by default.
Search
Recommended videos and next recommended video
Trending page
Desktop
Additional Information
local#parseLocalCollaboratorscould be completed using the sample in LuanRT/YouTube.js#1203 if #7872 is implemented.Also, the title for #7872 is "Show at least one channel link for videos with multiple collaborators", which is implemented in this MR, however, the description talks about displaying all the authors.