test: fix the 23 failing tests on main - #262
Merged
Merged
Conversation
Test files run as concurrent tabs. A browser produces no frames for a tab that is not the visible one, so anything awaiting a frame never settled and 19 tests timed out after 20s each. Turn on CDP focus emulation per page, so every page keeps getting frames. The other four failed on their own terms, all from waiting a fixed number of ticks or pinning one browser's output: - three i18n tests waited a fixed number of ticks for a translation bundle that now needs one more, so they wait for the bundle instead; - the payment card embed pinned one browser's serialization of the Lumo font stack, so it resolves that stack through the browser instead. Producing frames again also surfaced a notice that was previously never reached. `ResponsiveMixin` sets attributes on the element it observes, which can resize it again in the same cycle; the browser's "ResizeObserver loop completed with undelivered notifications" then lands on window.onerror and counts against whichever test is running. Drop that one message before the handler sees it - "loop limit exceeded" is a real runaway loop and must still fail. Without this, foxy-tax-form and foxy-template-config-form fail. CHROME_PATH now overrides the browser location. The default is unchanged, so CI is unaffected; it is what makes the suite runnable off Linux. Before: 23 failures in 5 groups. After: 177/177 groups green, 7397 passed. Verified per group; a single group globbing all of ./src is not a reliable way to run this suite.
brettflorio
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bunch of test issues we've had for ages.
executablePathnow honoursCHROME_PATH. The default is unchanged, so CI is unaffected; it is what makes the suite runnable off Linux.