Treat response deserialization failures as request errors - #33
Merged
Conversation
ejsmith
marked this pull request as ready for review
July 28, 2026 23:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FetchClientDeserializationErrorwhen a successful response body cannot be read or parsed as JSONerrorCallback, avoid caching them, and always clear request loading countersRoot cause
getJSONResponsecaught body-read and JSON parsing failures and assigned a generatedProblemDetailsinstance toresponse.data. Because the original HTTP response could still haveok === true, callers and query libraries treated that problem object as successful typed data.Behavior change
Successful responses with invalid JSON now reject with
FetchClientDeserializationError. The error exposes the underlyingFetchClientResponse, parsing/readingcause, andresponseText. Caller cancellation is not wrapped: the request rejects with the signal's original abort reason.shouldThrowOnUnexpectedStatusCodesremains limited to HTTP status handling. AnerrorCallbackcan still explicitly suppress a deserialization error by returningtrue, in which casedataisnullrather thanProblemDetails.Actual non-success HTTP responses continue to populate
response.problemand use existing status handling.Validation
deno task format-checkdeno task lintdeno task checkdeno task test— 200 passeddeno task build --set-version 0.0.0 --allow-dirtyFetchClientDeserializationErrorgit diff --checkCloses #31