Skip to content

chore: add-lsp-plugin #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ryanbas21 wants to merge 3 commits into
base: main
Choose a base branch
from
+131 −1
Open

chore: add-lsp-plugin #576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0fc0b6
chore: add-lsp-plugin \r https://github.com/microsoft/typescript-go
ryanbas21 Apr 21, 2026
ab11424
chore: remove-package
ryanbas21 May 5, 2026
ac7bd0e
chore: pr-comments
ryanbas21 May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@
"@commitlint/config-conventional": "^20.0.0",
"@commitlint/prompt": "^20.0.0",
"@effect/cli": "catalog:effect",
"@effect/language-service": "catalog:effect",
"@effect/tsgo": "^0.5.1",

@coderabbitai coderabbitai Bot May 5, 2026 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Missing required companion package @typescript/native-preview.

The @effect/tsgo docs state: "At the moment, you still need the standard native TypeScript install (@typescript/native-preview) alongside @effect/tsgo." Without it, developers configuring their editor to use effect-tsgo as the language server may encounter failures.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@package.json` at line 55, The package.json is missing the required companion
package `@typescript/native-preview` required by `@effect/tsgo`; add
"@typescript/native-preview": "<latest-compatible-version>" alongside
"@effect/tsgo" in your dependencies or devDependencies in package.json (near the
existing "@effect/tsgo" entry) and run your package manager to install so the
effect-tsgo language server works correctly.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🌐 Web query:

What is the latest stable version of @effect/tsgo on npm? Is 0.5.1 still current?

💡 Result:

Latest stable version of @effect/tsgo on npm: 0.5.1 (i.e., 0.5.1 is the most recent released patch listed for the @effect/tsgo package in the project’s changelog) [1]. Is 0.5.1 still current as of 2026-05-05? Yes—there’s an explicit 0.5.1 entry in the @effect/tsgo changelog [1], and the repository’s recent release automation shows version packaging activity around later dates without contradicting 0.5.1 being the latest for the root @effect/tsgo package [2][3]. Note: @effect/tsgo is described by the project as “currently in Alpha,” so “stable” here refers to the latest published release number, not to a non-alpha maturity level [4].

Citations:

🏁 Script executed:

# Check if `@typescript/native-preview` is in package.json
rg "@typescript/native-preview" package.json

Repository: ForgeRock/ping-javascript-sdk

Length of output: 55

🏁 Script executed:

# List all dependencies and devDependencies in package.json to verify `@effect/tsgo` context
cat -n package.json | sed -n '40,70p'

Repository: ForgeRock/ping-javascript-sdk

Length of output: 1203

Pin @effect/tsgo to an exact version — it's explicitly Alpha.

@effect/tsgo is in Alpha and the upstream project warns to expect breaking changes between releases. Using ^0.5.1 allows automatic minor bumps that can silently break the plugin configuration committed in tsconfig.base.json.

Pin to the exact version to prevent uncontrolled upgrades:

📌 Proposed fix 
-    "@effect/tsgo": "^0.5.1",
+    "@effect/tsgo": "0.5.1",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"@effect/tsgo": "^0.5.1",
"@effect/tsgo": "0.5.1",
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@package.json` at line 55, The package dependency "@effect/tsgo": "^0.5.1"
should be pinned to an exact version to avoid automatic minor/patch upgrades;
update the dependency entry in package.json by replacing the caret semver
specifier (e.g., "^0.5.1") with the exact version string (e.g., "0.5.1") for the
"@effect/tsgo" dependency so the project will not pull in unintended breaking
changes from Alpha releases.

@ancheetah ancheetah May 7, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryanbas21 The docs do mention that you need to install @typescript/native-preview alongside. Regarding the version pinning, might be a good idea to avoid breaking changes for now but nbd.

@coderabbitai coderabbitai Bot May 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!

@ryanbas21 ryanbas21 May 7, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we can do this, but i'm not sure the affects on a workspace. You can install tsgo on your system or just use regular typescript before tsgo. the language service should work either way

@ancheetah ancheetah May 7, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to switch from tsgo to language-service?

"@eslint/eslintrc": "^3.0.0",
"@eslint/js": "~9.39.0",
"@evilmartians/lefthook": "^2.1.4",
Expand Down
76 changes: 76 additions & 0 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

54 changes: 53 additions & 1 deletion tsconfig.base.json
View file
Open in desktop

@ancheetah ancheetah May 7, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the comments from this json? Looks like it's causing syntax errors

@ryanbas21 ryanbas21 May 7, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it shouldn't cause errors, i probably use jsonc. where are the errors?

@ancheetah ancheetah May 7, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it was just a syntax highlighting thing in github

Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,58 @@
"declaration": true,
"declarationMap": true,
"skipLibCheck": true,
"baseUrl": "."
"baseUrl": ".",
"plugins": [
{
"name": "@effect/language-service",
Comment thread
coderabbitai[bot] marked this conversation as resolved.
"refactors": true,
"diagnostics": true,
"includeSuggestionsInTsc": true,
"quickinfo": true,
"completions": true,
"debug": false,
"goto": true,
"renames": true,
"ignoreEffectSuggestionsInTscExitCode": true,
"ignoreEffectWarningsInTscExitCode": false,
"ignoreEffectErrorsInTscExitCode": false,
"skipDisabledOptimization": false,
"mermaidProvider": "mermaid.live",
"noExternal": false,
"layerGraphFollowDepth": 0,
"inlays": false,
"namespaceImportPackages": [],
"barrelImportPackages": [],
"importAliases": {},
"topLevelNamedReexports": "ignore",
"keyPatterns": [
{
"target": "service",
"pattern": "default",
"skipLeadingPath": ["src/"]
},
{
"target": "custom",
"pattern": "default",
"skipLeadingPath": ["src/"]
}
],
"extendedKeyDetection": false,
"pipeableMinArgCount": 2,
"allowedDuplicatedPackages": [],
"effectFn": ["span"],
"diagnosticSeverity": {},
"overrides": [
{
"include": ["src/**/*.ts"],
"options": {
"diagnosticSeverity": {
"floatingEffect": "error"
}
}
}
]
}
]
}
}
Loading