Fix expert chat input focus on drawer open and after MQTT response#7933
Open
cstns wants to merge 4 commits into
Open
Fix expert chat input focus on drawer open and after MQTT response#7933cstns wants to merge 4 commits into
cstns wants to merge 4 commits into
Conversation
…' into fix/7931_expert-chat-input-focus
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7933 +/- ##
=======================================
Coverage 75.61% 75.62%
=======================================
Files 434 434
Lines 23232 23235 +3
Branches 6172 6174 +2
=======================================
+ Hits 17568 17571 +3
Misses 5664 5664
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
isWaitingForResponseinstead of chaining.then()onhandleQuery(). The old approach relied on the HTTP promise lifecycle wherehandleQueryresolves after the full response. Over MQTT,sendMqttQueryreturns immediately, so the.then()refocus fired before the response arrived and any DOM updates from the actual response would blur the input with nothing to restore it.Related Issue(s)
closes #7931
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel