feat(installer): Update installer for new async registration flow - #708
Open
knolleary wants to merge 11 commits into
Open
feat(installer): Update installer for new async registration flow#708knolleary wants to merge 11 commits into
knolleary wants to merge 11 commits into
Conversation
Member
Author
|
Given the installer release doesn't use release-please currently, I think I should make this a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the installer to work with the new async registration flow.
There is a big chicken/egg issue when it comes to testing this PR. It installs latest device agent code from npm - that's no good when you want to test installer changes alongside unpublished device agent changes.
I found a hacky workaround by temporarily modifying the installer code to install from a hardcoded local path rather than npm. Not entirely satisfactory.
But, it is true to say these installer updates do not need to merge at the same time as the setup PR. We can do a release of the updated device agent, then finish verification of the installer against the newly published version.
The main changes are:
### Future work
The original intent was to rework the whole sequence of steps the installer takes - to give the user more control. I have a local branch with that 90% done, but its a lot of work to fully test. So I've reduced the scope a lot to keep the same level of opinionated behaviour, but with the async registration supported.
I will raise separate issues to identify what needs doing next, but that doesn't block this iteration.