Skip to content

#6297 Improve promises handling in ExpirationCache - #6298

Merged
sosnovsky merged 2 commits into
masterfrom
6297-expiration-cache-fix
Sep 22, 2026
Merged

sosnovsky merged 2 commits into
masterfrom
6297-expiration-cache-fix

Conversation

@sosnovsky

@sosnovsky sosnovsky commented Sep 22, 2026 •

Copy link
Copy Markdown
Collaborator

This PR fixes promise caching in ExpirationCache and corrects full-message cache eviction.

close #6297


Tests (delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@sosnovsky
sosnovsky requested a review from martgil September 22, 2026 11:13
@sosnovsky
sosnovsky marked this pull request as ready for review September 22, 2026 11:13

@martgil martgil left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice cleanup 👍

@sosnovsky
sosnovsky enabled auto-merge (squash) September 22, 2026 12:30
@sosnovsky
sosnovsky merged commit 94eec15 into master Sep 22, 2026
12 checks passed
@sosnovsky
sosnovsky deleted the 6297-expiration-cache-fix branch September 22, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve ExpirationCache promises cache implementation

2 participants