Skip to content

#6289 Fix extension popup width - #6290

Merged
sosnovsky merged 4 commits into
masterfrom
6289-extension-popup-fix-live-test
Sep 16, 2026
Merged

sosnovsky merged 4 commits into
masterfrom
6289-extension-popup-fix-live-test

Conversation

@sosnovsky

@sosnovsky sosnovsky commented Sep 16, 2026 •

Copy link
Copy Markdown
Collaborator

This PR fixes extension popup width

close #6289


Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@sosnovsky
sosnovsky requested a review from martgil September 16, 2026 09:47
@sosnovsky

Copy link
Copy Markdown
Collaborator Author

Hi @martgil, I updated our css to set a fixed width for the extension popup and it fixed original issue for me. Please check if it works correctly for you too, thanks!

@martgil

martgil commented Sep 16, 2026 •

Copy link
Copy Markdown
Collaborator

You're too fast - I also have the fix for this one too haha. I'll check.

Comment thread extension/css/browser-popup.css Outdated
@sosnovsky
sosnovsky marked this pull request as ready for review September 16, 2026 09:58
@sosnovsky
sosnovsky requested a review from martgil September 16, 2026 09:58
Comment thread extension/chrome/popups/default.htm
@sosnovsky
sosnovsky requested a review from martgil September 16, 2026 10:12
martgil
martgil previously approved these changes Sep 16, 2026

@martgil martgil left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now. Thanks!

@sosnovsky

Copy link
Copy Markdown
Collaborator Author

Hi @martgil, can you please re-approve this PR, there were some failing tests. Thanks!

@sosnovsky
sosnovsky merged commit d2f773f into master Sep 16, 2026
12 checks passed
@sosnovsky
sosnovsky deleted the 6289-extension-popup-fix-live-test branch September 16, 2026 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extension pop-up not working

2 participants