Skip to content

#6256 Improve regex for checking remote image url - #6257

Merged
sosnovsky merged 5 commits into
masterfrom
issue-6256-improve-image-url-checking
Jul 7, 2026
Merged

sosnovsky merged 5 commits into
masterfrom
issue-6256-improve-image-url-checking

Conversation

@martgil

@martgil martgil commented Jul 6, 2026 •

Copy link
Copy Markdown
Collaborator

This PR improves the url matching for images.

close #6256


Tests (delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@martgil
martgil requested a review from sosnovsky as a code owner July 6, 2026 09:53
@martgil
martgil marked this pull request as draft July 6, 2026 09:53
@martgil

martgil commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator Author

wip: currently adding a test

@martgil
martgil marked this pull request as ready for review July 7, 2026 03:35
@martgil

This comment was marked as outdated.

Comment thread extension/js/common/core/common.ts Outdated
@martgil
martgil requested a review from sosnovsky July 7, 2026 09:55
@martgil

martgil commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator Author

Hi @sosnovsky - This one is ready for a review. Thank you!

@sosnovsky sosnovsky left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good now 👍

@sosnovsky
sosnovsky merged commit bbd4b41 into master Jul 7, 2026
12 checks passed
@sosnovsky
sosnovsky deleted the issue-6256-improve-image-url-checking branch July 7, 2026 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve image url checking

2 participants