Repository navigation
fix(music): skip on the player instead of rebuilding the queue - #1797
Merged
Merged
Conversation
A-EDev
force-pushed
the
fix/music-next-gap
branch
from
November 6, 2026 17:37
1e32646 to
cb79ad6
Compare
A-EDev
force-pushed
the
fix/music-next-gap
branch
from
November 7, 2026 09:27
cb79ad6 to
f261f94
Compare
A-EDev
marked this pull request as ready for review
November 7, 2026 09:57
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LaunchedEffectinFullMusicPlayerContentcould replay a song as a one-song queue, and it now only loads lyrics.shouldShowPlayButton, so Pause works while the next song buffers.Related issue
Closes #1761
Change type
Validation
./gradlew :app:assembleGithubDebug: passed./gradlew :app:testGithubDebugUnitTest: 5352 tests, 0 failures, 46 skipped:app:compileFossDebugKotlin,ktlintCheckandnightly_notes.py --checkpassTest device and Android version: Xiaomi 2311DRK48G, Android 16, debug builds. Audio was recorded from the phone with scrcpy; silence means samples at or below 8 of 32767 for at least 30 ms. Presses were
adb input tap, 9 s apart, so press times include its delay.Fast presses, Pause straight after Next, and Next then Previous behaved correctly. Song order varied a little between runs, and a song's quiet intro counts as silence.
Not tested: the notification and headset buttons themselves (media keys were sent with
cmd media_session dispatch), Bluetooth, a release build, and data or battery cost.Screenshots or recordings
Risk and compatibility
Player path. With crossfade off, the old song jumps forward during a skip: 1.1 to 1.5 s, up to 4.9 s on the first skip after opening a song. It is heard for about half a second before the new song takes over. Each in-app skip briefly runs a second player, which loads about 3 s of the old song. During a hold the notification shows the old song while the app already shows the new one.
These change with Next and Previous and now match auto-advance and the notification: "Playing from" stays the queue's source instead of turning into "Radio", a named radio station stays active, play context genre is kept, skipping onto a song from Add to queue no longer reseeds radio, a repeated song plays its own queue entry, and player items keep their existing metadata. Tapping the spinner while buffering now pauses. Auto crossfade's line-up moved to
TailAligneras it was. A debug log line was added for each skip route. No preference or database changes.