Skip to content

fix(wellbeing): keep one day chosen on the watch time chart - #1789

Merged
A-EDev merged 3 commits into
mainfrom
fix/wellbeing-chart-selection
Nov 6, 2026
Merged

A-EDev merged 3 commits into
mainfrom
fix/wellbeing-chart-selection

Conversation

@A-EDev

@A-EDev A-EDev commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • The chart opens on today and one day is always chosen, so the red bar always matches the number above it. A second tap changes nothing.
  • The daily average moves to the line under the number.
  • The chart bars no longer ripple. The colour change and haptic stay.
  • The week updates at midnight if the page is left open.

Related issue

Closes #1762
Closes #1763

Change type

  • Bug fix
  • Feature
  • Refactor or maintenance
  • Build, packaging, or CI
  • Documentation

Validation

  • ./gradlew :app:assembleGithubDebug: passed, with the five PRs of this round merged onto main 367296b
  • ./gradlew :app:testGithubDebugUnitTest: 5136 tests, 0 failures, 46 skipped, on the same merge
  • I ran any additional flavor-specific build or test tasks affected by this change. :app:compileFossDebugKotlin and nightly_notes.py --check pass, ktlintCheck passes on this branch
  • I manually tested the affected behavior on an Android device or emulator.

Test device and Android version: Android emulator, Android 17, 1080x2400, debug build. Opened Wellbeing and saw today chosen. Tapped Tuesday: name, time and red bar changed, with no ripple. Tapped it again: nothing changed. Tapped Thursday: it showed Yesterday with its time.

Screenshots or recordings

Risk and compatibility

No preference, database or player path changes. daily_average_label and settings_watch_time_week_total are removed from values/strings.xml, and the new sub line shows in English until translated. With the indication removed, a keyboard or D-pad focus shows no highlight on the bars.

  • The change does not introduce secrets, private data, or unexpected telemetry.
  • New user-facing text uses Android string resources.
  • Dependency and lockfile changes are intentional and limited to this PR.
  • Room schema changes include the required version bump and migration, or this PR does not change the Room schema.
  • Breaking changes and upgrade steps are clearly documented.

Copilot AI balanced review requested due to automatic review settings November 6, 2026 14:26

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@github-actions github-actions Bot added documentation Improvements or additions to documentation ui Compose UI, theming, or Material 3 surfaces labels Nov 6, 2026
@A-EDev
A-EDev force-pushed the fix/wellbeing-chart-selection branch from 831513a to 9b47972 Compare November 6, 2026 17:01
@A-EDev
A-EDev merged commit 0451dc0 into main Nov 6, 2026
9 checks passed
@A-EDev
A-EDev deleted the fix/wellbeing-chart-selection branch November 6, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ui Compose UI, theming, or Material 3 surfaces

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Digital Wellbeing tapping Animation releted [Bug]: Digital Wellbeing tap releted

2 participants