Repository navigation
feat(lyrics): show the current line on the lock screen - #1774
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
…to feat/session-lyrics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related issue
Closes #1742
Change type
Validation
./gradlew :app:assembleGithubDebug: passed./gradlew :app:testGithubDebugUnitTest: passed, 5076 tests, 0 failed, 2 skipped./gradlew ktlintCheck :app:compileFossDebugKotlin: passedChecked on the emulator with
dumpsys media_session,dumpsys notificationand screenshots: title and artist follow the lines, the real song returns with the screen off and resumes with it on, pausing holds the line, and Flow's own player keeps the song's name. Long lines were checked on the emulator: "A full commitment's what I'm thinkin' of" shows as two parts in step with the song. On the phone, screenshots show parts of long lines on the lock screen ("Never gonna run") and the shade ("too blind to see"), and the session title moved through the parts in step with the song. Control Center was not rechecked with the split. The timing slider was checked on the emulator only: with the song paused, the earlier end moved the session title to the next line and the later end to the previous line, the centre restored it, and the slider appears only with the switch on.Test device and Android version: Xiaomi 2311DRK48G, HyperOS 3, Android 16; Android emulator, API 37
Screenshots or recordings
Risk and compatibility
New preference key
lyrics_on_lock_screen, default off. With it off, the session state is unchanged.Other apps reading now playing see the lyric as the title, so scrobblers may record lyric lines as songs. The setting's summary says so and it is off by default.
Bluetooth car displays may treat each line as a track change. Not tested.
Each new line updates the session metadata and the notification once. Updates stop with the screen off unless a car is connected. Android Auto is untested.
This raises the rate of
MediaSession.setMetadatacalls, the path behind the [Bug]: cannot use a recycled source in createBitmap #1017 and [Bug]: IllegalArgumentException in Bitmap.java:942 #1231 recycled bitmap crash. No ROM with that crash has been tested.Media3MusicServiceis over the file size ceiling. It grows by 2 net lines here, with the logic in new files, because the player path shouldn't be restructured as cleanup.DevicePreferencesSplitTestcounts keys, so it needs its count adjusted if another PR adding keys merges first.The change does not introduce secrets, private data, or unexpected telemetry.
New user-facing text uses Android string resources.
Dependency and lockfile changes are intentional and limited to this PR.
Room schema changes include the required version bump and migration, or this PR does not change the Room schema.
Breaking changes and upgrade steps are clearly documented.