Skip to content

feat(lyrics): add colorful and moving backgrounds made from the cover - #1773

Merged
A-EDev merged 2 commits into
mainfrom
feat/lyrics-sheet-background
Nov 6, 2026
Merged

A-EDev merged 2 commits into
mainfrom
feat/lyrics-sheet-background

Conversation

@A-EDev

@A-EDev A-EDev commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Adds a Background row to the lyrics actions sheet: Solid (today, the default), Colorful and Moving.
  • Colorful draws soft colors from a tiny copy of the cover. It uses no blur effect, so it also works below Android 12.
  • Moving lays two copies of that field over each other on different paths, so the colors flow through each other.
  • Lyric text is measured against the brightest cell under a scrim, and stays opaque so [Bug]: white line on lyrics #1484 can't return.

This adds a new ambient surface to the lyrics sheet, which the project owner approved for this sheet.

Related issue

Closes #1739

Change type

  • Bug fix
  • Feature
  • Refactor or maintenance
  • Build, packaging, or CI
  • Documentation

Validation

  • ./gradlew :app:assembleGithubDebug: passed
  • ./gradlew :app:testGithubDebugUnitTest: passed, 5067 tests, 0 failed, 2 skipped
  • ./gradlew ktlintCheck :app:compileFossDebugKotlin: passed
  • I manually tested the affected behavior on an Android device or emulator.

Measured on the phone with the lyrics sheet open and a song playing, at 120 Hz. Each run used whichever song was playing, so CPU varies by song and these are not a controlled comparison:

Style Process CPU Janky frames
Solid 137% 0
Colorful 122% 0
Moving 133% 0

Moving rendered 0 frames over 8 to 12 seconds while paused. It redraws at 24 fps at most and stops with the sheet, the song, the screen and the system's animation setting.

Test device and Android version: Xiaomi 2311DRK48G, HyperOS 3, Android 16; Android emulator, API 37

Screenshots or recordings

Risk and compatibility

New preference key lyrics_background, default Solid, which leaves today's sheet unchanged. The cover loads only while the style is on and the sheet is visible. DevicePreferencesSplitTest counts keys, so it needs its count adjusted if another PR adding keys merges first.

  • The change does not introduce secrets, private data, or unexpected telemetry.
  • New user-facing text uses Android string resources.
  • Dependency and lockfile changes are intentional and limited to this PR.
  • Room schema changes include the required version bump and migration, or this PR does not change the Room schema.
  • Breaking changes and upgrade steps are clearly documented.

Copilot AI balanced review requested due to automatic review settings November 5, 2026 22:55

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@github-actions github-actions Bot added documentation Improvements or additions to documentation ui Compose UI, theming, or Material 3 surfaces labels Nov 5, 2026
…kground

# Conflicts:
#	app/src/test/java/io/github/aedev/flow/data/local/DevicePreferencesSplitTest.kt
@A-EDev
A-EDev merged commit d001f86 into main Nov 6, 2026
9 checks passed
@A-EDev
A-EDev deleted the feat/lyrics-sheet-background branch November 6, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ui Compose UI, theming, or Material 3 surfaces

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Colourful & Dynamic Background

2 participants