Repository navigation
feat(lyrics): add colorful and moving backgrounds made from the cover - #1773
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
…kground # Conflicts: # app/src/test/java/io/github/aedev/flow/data/local/DevicePreferencesSplitTest.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds a new ambient surface to the lyrics sheet, which the project owner approved for this sheet.
Related issue
Closes #1739
Change type
Validation
./gradlew :app:assembleGithubDebug: passed./gradlew :app:testGithubDebugUnitTest: passed, 5067 tests, 0 failed, 2 skipped./gradlew ktlintCheck :app:compileFossDebugKotlin: passedMeasured on the phone with the lyrics sheet open and a song playing, at 120 Hz. Each run used whichever song was playing, so CPU varies by song and these are not a controlled comparison:
Moving rendered 0 frames over 8 to 12 seconds while paused. It redraws at 24 fps at most and stops with the sheet, the song, the screen and the system's animation setting.
Test device and Android version: Xiaomi 2311DRK48G, HyperOS 3, Android 16; Android emulator, API 37
Screenshots or recordings
Risk and compatibility
New preference key
lyrics_background, default Solid, which leaves today's sheet unchanged. The cover loads only while the style is on and the sheet is visible.DevicePreferencesSplitTestcounts keys, so it needs its count adjusted if another PR adding keys merges first.